Paths

Table of Contentst

Differential D20538

Recognize self-URI links to Diffusion files and give them special rendering behavior
ClosedPublic
Actions

Authored by epriestley on May 21 2019, 4:46 PM.

Tags

None

Referenced Files

	F14306439: D20538.diff
	Tue, Dec 17, 10:25 PM

	Unknown Object (File)
	Tue, Dec 10, 6:48 PM

	Unknown Object (File)
	Tue, Dec 10, 6:48 PM

	Unknown Object (File)
	Tue, Dec 10, 6:42 PM

	Unknown Object (File)
	Tue, Dec 10, 6:26 PM

	Unknown Object (File)
	Thu, Dec 5, 7:49 AM

	Unknown Object (File)
	Wed, Nov 27, 11:22 PM

	Unknown Object (File)
	Wed, Nov 27, 5:10 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion

Commits

rP56e7bde68d9b: Recognize self-URI links to Diffusion files and give them special rendering…

Summary

Depends on D20530. Ref T13291. When users paste links to files in Diffusion into remarkup contexts, identify them and specialize the rendering.

When the URIs are embedded with {...}, parse them in more detail.

This is a lead-up to a {src ...} rule which will use the same View but give users more options to customize presentation.

Test Plan

Screen Shot 2019-05-21 at 9.43.02 AM.png (553×706 px, 52 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 21 2019, 4:46 PM

Harbormaster completed remote builds in B22845: Diff 48969.May 21 2019, 4:48 PM

epriestley requested review of this revision.May 21 2019, 4:48 PM

epriestley added inline comments.May 21 2019, 4:56 PM

src/applications/diffusion/request/DiffusionRequest.php
31–35	Currently "branch support" is a property of `DiffusionRequest`, which is mostly a URI-parsing/routing class that handles bundling up and unbundling all the commit/path/line/branch information in a `source/xyz/master/path/to/thing.c;abcd1234$12` URI. This is a legacy sort of thing; I moved it to `Repository` instead.
src/applications/meta/engineextension/PhabricatorSelfHyperlinkEngineExtension.php
18–26	I pulled this piece of logic ("find all the URIs which point to this install [with an HTTP/HTTPS protocol]") up into a parent class.

epriestley added a child revision: D20539: Add a "{src ...}" Remarkup rule to provide a more flexible way to reference source files in Diffusion.May 21 2019, 7:01 PM

amckinley accepted this revision.May 21 2019, 7:09 PM

This revision is now accepted and ready to land.May 21 2019, 7:09 PM

Closed by commit rP56e7bde68d9b: Recognize self-URI links to Diffusion files and give them special rendering… (authored by epriestley). · Explain WhyMay 21 2019, 8:07 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP56e7bde68d9b: Recognize self-URI links to Diffusion files and give them special rendering….

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

diffusion/

engineextension/

DiffusionSourceHyperlinkEngineExtension.php

84 lines

request/

DiffusionGitRequest.php

4 lines

DiffusionMercurialRequest.php

4 lines

DiffusionRequest.php

5 lines

DiffusionSvnRequest.php

4 lines

view/

DiffusionSourceLinkView.php

208 lines

doorkeeper/

engineextension/

DoorkeeperHyperlinkEngineExtension.php

2 lines

meta/

engineextension/

PhabricatorSelfHyperlinkEngineExtension.php

12 lines

remarkup/

engineextension/

PhabricatorRemarkupHyperlinkEngineExtension.php

32 lines

repository/

storage/

PhabricatorRepository.php

9 lines

Diff 48982

src/__phutil_library_map__.php

Loading...

src/applications/diffusion/engineextension/DiffusionSourceHyperlinkEngineExtension.php

Loading...

src/applications/diffusion/request/DiffusionGitRequest.php

Loading...

src/applications/diffusion/request/DiffusionMercurialRequest.php

Loading...

src/applications/diffusion/request/DiffusionRequest.php

Loading...

src/applications/diffusion/request/DiffusionSvnRequest.php

Loading...

src/applications/diffusion/view/DiffusionSourceLinkView.php

Loading...

src/applications/doorkeeper/engineextension/DoorkeeperHyperlinkEngineExtension.php

Loading...

src/applications/meta/engineextension/PhabricatorSelfHyperlinkEngineExtension.php

Loading...

src/applications/remarkup/engineextension/PhabricatorRemarkupHyperlinkEngineExtension.php

Loading...

src/applications/repository/storage/PhabricatorRepository.php

Loading...