Page MenuHomePhabricator

Recognize self-URI links to Diffusion files and give them special rendering behavior
ClosedPublic

Authored by epriestley on May 21 2019, 4:46 PM.
Tags
None
Referenced Files
F17670152: D20538.id48982.diff
Sun, Jul 13, 12:59 AM
Unknown Object (File)
Jun 5 2025, 4:24 PM
Unknown Object (File)
May 30 2025, 10:15 AM
Unknown Object (File)
May 29 2025, 10:01 AM
Unknown Object (File)
May 28 2025, 1:19 PM
Unknown Object (File)
May 8 2025, 5:13 AM
Unknown Object (File)
May 7 2025, 3:23 AM
Unknown Object (File)
Apr 29 2025, 10:24 AM
Subscribers
None

Details

Summary

Depends on D20530. Ref T13291. When users paste links to files in Diffusion into remarkup contexts, identify them and specialize the rendering.

When the URIs are embedded with {...}, parse them in more detail.

This is a lead-up to a {src ...} rule which will use the same View but give users more options to customize presentation.

Test Plan

Screen Shot 2019-05-21 at 9.43.02 AM.png (553×706 px, 52 KB)

Diff Detail

Repository
rP Phabricator
Branch
src1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22845
Build 31344: Run Core Tests
Build 31343: arc lint + arc unit

Event Timeline

src/applications/diffusion/request/DiffusionRequest.php
31–33

Currently "branch support" is a property of DiffusionRequest, which is mostly a URI-parsing/routing class that handles bundling up and unbundling all the commit/path/line/branch information in a source/xyz/master/path/to/thing.c;abcd1234$12 URI.

This is a legacy sort of thing; I moved it to Repository instead.

src/applications/meta/engineextension/PhabricatorSelfHyperlinkEngineExtension.php
18–26

I pulled this piece of logic ("find all the URIs which point to this install [with an HTTP/HTTPS protocol]") up into a parent class.

This revision is now accepted and ready to land.May 21 2019, 7:09 PM