Page MenuHomePhabricator

Add a 15-second timeout to external service calls to fill Doorkeeper link tags
ClosedPublic

Authored by epriestley on May 20 2019, 6:45 PM.
Tags
None
Referenced Files
F18878572: D20530.id.diff
Thu, Nov 6, 5:25 PM
F18876041: D20530.diff
Wed, Nov 5, 9:16 PM
F18815828: D20530.diff
Oct 21 2025, 3:52 AM
F18780498: D20530.id48957.diff
Oct 12 2025, 4:37 PM
F18758963: D20530.diff
Oct 6 2025, 12:53 AM
F18754617: D20530.id48975.diff
Oct 4 2025, 11:58 PM
F18742104: D20530.id.diff
Oct 2 2025, 5:26 PM
F18739535: D20530.diff
Oct 1 2025, 9:51 PM
Subscribers
None

Details

Summary

Depends on D20528. Ref T13291. Ref T13285. Currently, we don't put a timeout on external service calls when enriching URIs for external Asana/JIRA tasks.

Add a 15-second timeout so we'll do something reasonable-ish in the face of a downed service provider. Later, I plan to healthcheck Asana/JIRA providers in a generic way (see T13287) so we can stop making calls if they time out / fail too frequently.

Test Plan
  • Linked to JIRA and Asana tasks in comments.
  • Set timeout to 0.0001 seconds, saw requests time out.

Diff Detail

Repository
rP Phabricator
Branch
doorkeeper3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22833
Build 31321: Run Core Tests
Build 31320: arc lint + arc unit