Page MenuHomePhabricator

Add a 15-second timeout to external service calls to fill Doorkeeper link tags
ClosedPublic

Authored by epriestley on May 20 2019, 6:45 PM.
Tags
None
Referenced Files
F14091627: D20530.id48957.diff
Mon, Nov 25, 1:09 AM
F14090300: D20530.id48975.diff
Sun, Nov 24, 5:05 PM
Unknown Object (File)
Thu, Nov 21, 10:07 PM
Unknown Object (File)
Fri, Nov 8, 8:25 AM
Unknown Object (File)
Tue, Nov 5, 12:21 AM
Unknown Object (File)
Sun, Nov 3, 5:43 AM
Unknown Object (File)
Fri, Nov 1, 2:00 PM
Unknown Object (File)
Oct 23 2024, 11:17 PM
Subscribers
None

Details

Summary

Depends on D20528. Ref T13291. Ref T13285. Currently, we don't put a timeout on external service calls when enriching URIs for external Asana/JIRA tasks.

Add a 15-second timeout so we'll do something reasonable-ish in the face of a downed service provider. Later, I plan to healthcheck Asana/JIRA providers in a generic way (see T13287) so we can stop making calls if they time out / fail too frequently.

Test Plan
  • Linked to JIRA and Asana tasks in comments.
  • Set timeout to 0.0001 seconds, saw requests time out.

Diff Detail

Repository
rP Phabricator
Branch
doorkeeper3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22833
Build 31321: Run Core Tests
Build 31320: arc lint + arc unit