Page MenuHomePhabricator

Add a 15-second timeout to external service calls to fill Doorkeeper link tags
ClosedPublic

Authored by epriestley on May 20 2019, 6:45 PM.
Tags
None
Referenced Files
F17464989: D20530.diff
Tue, Jul 1, 10:15 PM
Unknown Object (File)
Sun, Jun 29, 9:06 PM
Unknown Object (File)
Fri, Jun 27, 5:07 PM
Unknown Object (File)
Thu, Jun 5, 4:24 PM
Unknown Object (File)
May 28 2025, 5:10 PM
Unknown Object (File)
May 27 2025, 8:51 PM
Unknown Object (File)
May 9 2025, 12:43 PM
Unknown Object (File)
May 2 2025, 11:57 AM
Subscribers
None

Details

Summary

Depends on D20528. Ref T13291. Ref T13285. Currently, we don't put a timeout on external service calls when enriching URIs for external Asana/JIRA tasks.

Add a 15-second timeout so we'll do something reasonable-ish in the face of a downed service provider. Later, I plan to healthcheck Asana/JIRA providers in a generic way (see T13287) so we can stop making calls if they time out / fail too frequently.

Test Plan
  • Linked to JIRA and Asana tasks in comments.
  • Set timeout to 0.0001 seconds, saw requests time out.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable