Page MenuHomePhabricator

Add a 15-second timeout to external service calls to fill Doorkeeper link tags
ClosedPublic

Authored by epriestley on May 20 2019, 6:45 PM.
Tags
None
Referenced Files
F19894259: D20530.diff
Sat, Mar 28, 1:29 PM
F19878032: D20530.diff
Mon, Mar 16, 9:16 PM
F19802290: D20530.diff
Mar 1 2026, 3:33 PM
F19799309: D20530.diff
Feb 27 2026, 11:21 PM
F19726644: D20530.id48975.diff
Feb 13 2026, 6:50 PM
F19543968: D20530.diff
Jan 23 2026, 1:38 AM
F19084863: D20530.diff
Dec 2 2025, 4:39 PM
F19084856: D20530.diff
Dec 2 2025, 4:37 PM
Subscribers
None

Details

Summary

Depends on D20528. Ref T13291. Ref T13285. Currently, we don't put a timeout on external service calls when enriching URIs for external Asana/JIRA tasks.

Add a 15-second timeout so we'll do something reasonable-ish in the face of a downed service provider. Later, I plan to healthcheck Asana/JIRA providers in a generic way (see T13287) so we can stop making calls if they time out / fail too frequently.

Test Plan
  • Linked to JIRA and Asana tasks in comments.
  • Set timeout to 0.0001 seconds, saw requests time out.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable