Page MenuHomePhabricator

Fix a fatal when navigating to a Workboard after removing the Workboard menu item
ClosedPublic

Authored by epriestley on May 13 2019, 2:18 PM.
Tags
None
Referenced Files
F15413088: D20516.id48909.diff
Wed, Mar 19, 5:00 PM
Unknown Object (File)
Feb 19 2025, 8:42 PM
Unknown Object (File)
Feb 14 2025, 5:04 PM
Unknown Object (File)
Feb 13 2025, 8:07 AM
Unknown Object (File)
Feb 9 2025, 7:46 AM
Unknown Object (File)
Feb 9 2025, 7:46 AM
Unknown Object (File)
Feb 9 2025, 7:46 AM
Unknown Object (File)
Feb 9 2025, 7:46 AM
Subscribers
None

Details

Reviewers
amckinley
Summary

See PHI1247. If you remove the Workboard from a project profile menu, then navigate to the URI, we currently fatal when trying to select the "Workboard" item.

Instead, only try to select the item if some matching item is present.

Test Plan
  • Disabled the workboard on a project, navigated to /board/, got a sensible page with no navigation item selected instead of a fatal.
  • Viewed a normal workboard, saw the correct selection.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable