Page MenuHomePhabricator

Fix a fatal when navigating to a Workboard after removing the Workboard menu item
ClosedPublic

Authored by epriestley on May 13 2019, 2:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 5:20 PM
Unknown Object (File)
Sun, Nov 17, 2:33 AM
Unknown Object (File)
Thu, Nov 14, 6:57 AM
Unknown Object (File)
Thu, Nov 7, 11:08 AM
Unknown Object (File)
Sat, Nov 2, 7:17 AM
Unknown Object (File)
Oct 20 2024, 4:41 AM
Unknown Object (File)
Oct 19 2024, 12:36 PM
Unknown Object (File)
Oct 9 2024, 8:03 PM
Subscribers
None

Details

Reviewers
amckinley
Summary

See PHI1247. If you remove the Workboard from a project profile menu, then navigate to the URI, we currently fatal when trying to select the "Workboard" item.

Instead, only try to select the item if some matching item is present.

Test Plan
  • Disabled the workboard on a project, navigated to /board/, got a sensible page with no navigation item selected instead of a fatal.
  • Viewed a normal workboard, saw the correct selection.

Diff Detail

Repository
rP Phabricator
Branch
board1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22782
Build 31251: Run Core Tests
Build 31250: arc lint + arc unit