Paths

Table of Contentst

Differential D20488

Fix handling of "null" domain values in Charts
ClosedPublic
Actions

Authored by epriestley on Apr 30 2019, 4:43 PM.

Details

Reviewers

amckinley

Commits

rP10afe1f2b59c: Fix handling of "null" domain values in Charts

Summary

Depends on D20487. If you min(1, 2, null), you get null. We want 1.

Test Plan

Viewed a "burnup for project X" chart where one dataseries had no datapoints. Saw a sensible domain selected automatically.

Diff Detail

Repository

rP Phabricator

Branch

chart17

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22743
Build 31182: Run Core Tests
Build 31181: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 30 2019, 4:43 PM

Herald added a subscriber: yelirekim. · View Herald TranscriptApr 30 2019, 4:43 PM

Harbormaster completed remote builds in B22743: Diff 48870.Apr 30 2019, 4:45 PM

epriestley requested review of this revision.Apr 30 2019, 4:45 PM

epriestley added a child revision: D20489: Start the fact daemon in "bin/phd start".Apr 30 2019, 4:52 PM

If you min(1, 2, null), you get null.

frowncat

This revision is now accepted and ready to land.May 1 2019, 2:00 PM

For PHP, that's pretty good!

$ php -r 'echo min(array("mouse", "cat", "dog", "aardvark", "zebra"));'
aardvark

Closed by commit rP10afe1f2b59c: Fix handling of "null" domain values in Charts (authored by epriestley). · Explain WhyMay 22 2019, 11:51 AM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP10afe1f2b59c: Fix handling of "null" domain values in Charts.

epriestley mentioned this in rP10afe1f2b59c: Fix handling of "null" domain values in Charts.

Revision Contents
Changeset List

Path

Size

src/

applications/

fact/

chart/

PhabricatorHigherOrderChartFunction.php

8 lines

Diff 48870

View Options

src/applications/fact/chart/PhabricatorHigherOrderChartFunction.php

Fix handling of "null" domain values in ChartsClosedPublicActions