Differential D20424

Off"
ClosedPublic
Actions

Authored by epriestley on Apr 14 2019, 8:50 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs"

Commits

rPec9237fe13c5: In repository settings, fold "Autoclose On/Off" into "Publishing On/Off"

Summary

Depends on D20423. Ref T13277. Repositories currently have separate toggles for "Autoclose" and "Publishing".

Merge the "Autoclose" toggle into the "Publishing" toggle. I'm unaware of any valid use case for enabling one but not the other.

(This doesn't fix all the documentation, yet.)

Test Plan

Edited a repository, saw only one publishing option.

Diff Detail

Repository

rP Phabricator

Branch

autoclose8

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22596
Build 30957: Run Core Tests
Build 30956: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 14 2019, 8:50 PM

Harbormaster completed remote builds in B22596: Diff 48726.Apr 14 2019, 8:52 PM

epriestley requested review of this revision.Apr 14 2019, 8:52 PM

epriestley added a child revision: D20425: Move the repository "Publishing" option to the "Basics" panel in repository management.Apr 15 2019, 1:29 PM

amckinley accepted this revision.Apr 17 2019, 7:48 PM

This revision is now accepted and ready to land.Apr 17 2019, 7:48 PM

Closed by commit rPec9237fe13c5: In repository settings, fold "Autoclose On/Off" into "Publishing On/Off" (authored by epriestley). · Explain WhyApr 18 2019, 12:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

diffusion/

editor/

DiffusionCommitEditEngine.php

4 lines

DiffusionRepositoryEditEngine.php

15 lines

management/

DiffusionRepositoryActionsManagementPanel.php

DiffusionRepositoryBranchesManagementPanel.php

39 lines

	DiffusionRepositoryPublishingManagementPanel.php
	DiffusionRepositoryActionsManagementPanel.php

32 lines

view/

DiffusionBranchTableView.php

6 lines

repository/

storage/

PhabricatorRepository.php

8 lines

xaction/

PhabricatorRepositoryAutocloseTransaction.php

PhabricatorRepositoryNotifyTransaction.php

4 lines

Diff 48726

View Options

src/__phutil_library_map__.php

View Options

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

View Options

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

View Options

src/applications/diffusion/management/DiffusionRepositoryActionsManagementPanel.php

View Options

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php

View Options

src/applications/diffusion/management/DiffusionRepositoryPublishingManagementPanel.php

View Options

src/applications/diffusion/view/DiffusionBranchTableView.php

View Options

src/applications/repository/storage/PhabricatorRepository.php

View Options

src/applications/repository/xaction/PhabricatorRepositoryAutocloseTransaction.php

View Options

src/applications/repository/xaction/PhabricatorRepositoryNotifyTransaction.php

In repository settings, fold "Autoclose On/Off" into "Publishing On/Off"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48726

src/__phutil_library_map__.php

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

src/applications/diffusion/management/DiffusionRepositoryActionsManagementPanel.php

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php

src/applications/diffusion/management/DiffusionRepositoryPublishingManagementPanel.php

src/applications/diffusion/view/DiffusionBranchTableView.php

src/applications/repository/storage/PhabricatorRepository.php

src/applications/repository/xaction/PhabricatorRepositoryAutocloseTransaction.php

src/applications/repository/xaction/PhabricatorRepositoryNotifyTransaction.php

In repository settings, fold "Autoclose On/Off" into "Publishing On/Off"
ClosedPublic
Actions

Revision Contents
Changeset List