Page MenuHomePhabricator

Move Dashboards main edit flow to EditEngine
ClosedPublic

Authored by epriestley on Apr 11 2019, 10:46 PM.
Tags
None
Referenced Files
F14797129: D20403.id48692.diff
Sat, Jan 25, 4:42 AM
F14797128: D20403.id48686.diff
Sat, Jan 25, 4:42 AM
F14797127: D20403.id.diff
Sat, Jan 25, 4:42 AM
Unknown Object (File)
Tue, Jan 21, 11:44 PM
Unknown Object (File)
Tue, Jan 21, 4:04 PM
Unknown Object (File)
Tue, Jan 21, 9:45 AM
Unknown Object (File)
Mon, Jan 13, 4:42 PM
Unknown Object (File)
Tue, Dec 31, 1:27 PM
Subscribers
None

Details

Summary

Depends on D20402. Ref T13272. Replaces an old-school hard-coded "EditController" with a more modern one.

The actual panel stuff is still using a weird mix of legacy manual save() calls, but that's up next.

Test Plan

Created Dashboards, edited all dashboard fields via "Edit Dashboard".

Diff Detail

Repository
rP Phabricator
Branch
panel6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22557
Build 30894: Run Core Tests
Build 30893: arc lint + arc unit