Page MenuHomePhabricator
Differential D20403

Move Dashboards main edit flow to EditEngine
ClosedPublic
Actions

Authored by epriestley on Apr 11 2019, 10:46 PM.
Tags
None
Referenced Files
F18842845: D20403.id.diff
Tue, Oct 28, 6:55 PM
F18838287: D20403.diff
Mon, Oct 27, 10:07 AM
F18837224: D20403.id48692.diff
Mon, Oct 27, 4:41 AM
F18837223: D20403.id48686.diff
Mon, Oct 27, 4:41 AM
F18837222: D20403.id.diff
Mon, Oct 27, 4:41 AM
F18834165: D20403.diff
Sun, Oct 26, 7:01 AM
F18752953: D20403.diff
Oct 4 2025, 4:56 PM
F18744152: D20403.id48686.diff
Oct 3 2025, 2:04 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13272: Remove the hard-coded homepage, and other Dashboards improvements
Commits
rPce723f999db2: Move Dashboards main edit flow to EditEngine
Summary

Depends on D20402. Ref T13272. Replaces an old-school hard-coded "EditController" with a more modern one.

The actual panel stuff is still using a weird mix of legacy manual save() calls, but that's up next.

Test Plan

Created Dashboards, edited all dashboard fields via "Edit Dashboard".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 48692

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/dashboard/application/PhabricatorDashboardApplication.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardListController.php

Loading...
View Options

src/applications/dashboard/controller/dashboard/PhabricatorDashboardEditController.php

Loading...
View Options

src/applications/dashboard/editor/PhabricatorDashboardEditEngine.php

Loading...
View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
Phabricator · Built by Phacility