Page MenuHomePhabricator
Differential D20403

Move Dashboards main edit flow to EditEngine
ClosedPublic
Actions

Authored by epriestley on Apr 11 2019, 10:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 29, 6:41 AM
Unknown Object (File)
May 7 2025, 12:52 AM
Unknown Object (File)
Apr 12 2025, 9:04 PM
Unknown Object (File)
Apr 12 2025, 8:16 PM
Unknown Object (File)
Apr 11 2025, 6:41 PM
Unknown Object (File)
Apr 10 2025, 10:28 AM
Unknown Object (File)
Mar 28 2025, 3:53 PM
Unknown Object (File)
Mar 22 2025, 2:09 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13272: Remove the hard-coded homepage, and other Dashboards improvements
Commits
rPce723f999db2: Move Dashboards main edit flow to EditEngine
Summary

Depends on D20402. Ref T13272. Replaces an old-school hard-coded "EditController" with a more modern one.

The actual panel stuff is still using a weird mix of legacy manual save() calls, but that's up next.

Test Plan

Created Dashboards, edited all dashboard fields via "Edit Dashboard".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 48692

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/dashboard/application/PhabricatorDashboardApplication.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardListController.php

Loading...
View Options

src/applications/dashboard/controller/dashboard/PhabricatorDashboardEditController.php

Loading...
View Options

src/applications/dashboard/editor/PhabricatorDashboardEditEngine.php

Loading...
View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
Phabricator · Built by Phacility