Page MenuHomePhabricator

Move Dashboards main edit flow to EditEngine
ClosedPublic

Authored by epriestley on Thu, Apr 11, 10:46 PM.

Details

Summary

Depends on D20402. Ref T13272. Replaces an old-school hard-coded "EditController" with a more modern one.

The actual panel stuff is still using a weird mix of legacy manual save() calls, but that's up next.

Test Plan

Created Dashboards, edited all dashboard fields via "Edit Dashboard".

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Apr 11, 10:46 PM
epriestley requested review of this revision.Thu, Apr 11, 10:48 PM
amckinley accepted this revision.Thu, Apr 11, 11:00 PM
This revision is now accepted and ready to land.Thu, Apr 11, 11:00 PM
This revision was automatically updated to reflect the committed changes.