Paths

Table of Contentst

Differential D20403

Move Dashboards main edit flow to EditEngine
ClosedPublic
Actions

Authored by epriestley on Apr 11 2019, 10:46 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rPce723f999db2: Move Dashboards main edit flow to EditEngine

Summary

Depends on D20402. Ref T13272. Replaces an old-school hard-coded "EditController" with a more modern one.

The actual panel stuff is still using a weird mix of legacy manual save() calls, but that's up next.

Test Plan

Created Dashboards, edited all dashboard fields via "Edit Dashboard".

Diff Detail

Repository

rP Phabricator

Branch

panel6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22557
Build 30894: Run Core Tests
Build 30893: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 11 2019, 10:46 PM

Harbormaster completed remote builds in B22557: Diff 48686.Apr 11 2019, 10:48 PM

epriestley requested review of this revision.Apr 11 2019, 10:48 PM

amckinley accepted this revision.Apr 11 2019, 11:00 PM

This revision is now accepted and ready to land.Apr 11 2019, 11:00 PM

Closed by commit rPce723f999db2: Move Dashboards main edit flow to EditEngine (authored by epriestley). · Explain WhyApr 12 2019, 1:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

dashboard/

application/

PhabricatorDashboardApplication.php

4 lines

controller/

PhabricatorDashboardListController.php

8 lines

dashboard/

PhabricatorDashboardEditController.php

182 lines

editor/

PhabricatorDashboardEditEngine.php

107 lines

search/

controller/

PhabricatorApplicationSearchController.php

3 lines

Diff 48686

View Options

src/__phutil_library_map__.php

View Options

src/applications/dashboard/application/PhabricatorDashboardApplication.php

View Options

src/applications/dashboard/controller/PhabricatorDashboardListController.php

View Options

src/applications/dashboard/controller/dashboard/PhabricatorDashboardEditController.php

View Options

src/applications/dashboard/editor/PhabricatorDashboardEditEngine.php

View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Move Dashboards main edit flow to EditEngineClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48686

src/__phutil_library_map__.php

src/applications/dashboard/application/PhabricatorDashboardApplication.php

src/applications/dashboard/controller/PhabricatorDashboardListController.php

src/applications/dashboard/controller/dashboard/PhabricatorDashboardEditController.php

src/applications/dashboard/editor/PhabricatorDashboardEditEngine.php

src/applications/search/controller/PhabricatorApplicationSearchController.php

Move Dashboards main edit flow to EditEngine
ClosedPublic
Actions

Revision Contents
Changeset List