Page MenuHomePhabricator

Surface custom form instructions as a "Remarkup" field for the transaction layer
ClosedPublic

Authored by epriestley on Apr 10 2019, 4:37 PM.
Tags
None
Referenced Files
F19515222: D20387.diff
Wed, Jan 14, 9:24 AM
F19358329: D20387.id48650.diff
Fri, Dec 26, 8:10 AM
F19143477: D20387.diff
Dec 10 2025, 2:13 PM
F19141841: D20387.diff
Dec 10 2025, 1:32 PM
F19004872: D20387.id.diff
Nov 21 2025, 12:58 PM
F18905884: D20387.id48654.diff
Nov 8 2025, 4:01 PM
F18905883: D20387.id48650.diff
Nov 8 2025, 4:01 PM
F18905880: D20387.id.diff
Nov 8 2025, 4:01 PM
Subscribers
None
Tokens
"Love" token, awarded by amckinley.

Details

Summary

Ref T13263. See https://discourse.phabricator-community.org/t/image-uploads-for-forms-too-restricted-by-default/2594. Currently, when you add instructions to a custom form, we don't expose them as remarkup, so {Fxxx} references don't get attached correctly and won't get proper permissions.

Test Plan

Dragged-and-dropped an image into form instructions, saw the file attach to the form:

Screen Shot 2019-04-10 at 9.33.25 AM.png (499×650 px, 162 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable