Page MenuHomePhabricator

Surface custom form instructions as a "Remarkup" field for the transaction layer
ClosedPublic

Authored by epriestley on Apr 10 2019, 4:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 7:01 AM
Unknown Object (File)
Sat, May 4, 6:59 PM
Unknown Object (File)
Fri, May 3, 11:20 AM
Unknown Object (File)
Fri, May 3, 4:59 AM
Unknown Object (File)
Thu, May 2, 12:31 PM
Unknown Object (File)
Sun, Apr 28, 10:43 AM
Unknown Object (File)
Thu, Apr 25, 12:43 AM
Unknown Object (File)
Sun, Apr 21, 1:50 PM
Subscribers
None
Tokens
"Love" token, awarded by amckinley.

Details

Summary

Ref T13263. See https://discourse.phabricator-community.org/t/image-uploads-for-forms-too-restricted-by-default/2594. Currently, when you add instructions to a custom form, we don't expose them as remarkup, so {Fxxx} references don't get attached correctly and won't get proper permissions.

Test Plan

Dragged-and-dropped an image into form instructions, saw the file attach to the form:

Screen Shot 2019-04-10 at 9.33.25 AM.png (499×650 px, 162 KB)

Diff Detail

Repository
rP Phabricator
Branch
remarkup1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22525
Build 30841: Run Core Tests
Build 30840: arc lint + arc unit