Page MenuHomePhabricator

Surface custom form instructions as a "Remarkup" field for the transaction layer
ClosedPublic

Authored by epriestley on Apr 10 2019, 4:37 PM.
Tags
None
Referenced Files
F15425390: D20387.id48650.diff
Sun, Mar 23, 4:31 AM
F15368448: D20387.diff
Wed, Mar 12, 2:13 AM
Unknown Object (File)
Mon, Mar 3, 11:41 PM
Unknown Object (File)
Feb 24 2025, 2:35 AM
Unknown Object (File)
Feb 15 2025, 6:46 PM
Unknown Object (File)
Feb 15 2025, 6:46 PM
Unknown Object (File)
Feb 15 2025, 6:46 PM
Unknown Object (File)
Jan 31 2025, 3:36 PM
Subscribers
None
Tokens
"Love" token, awarded by amckinley.

Details

Summary

Ref T13263. See https://discourse.phabricator-community.org/t/image-uploads-for-forms-too-restricted-by-default/2594. Currently, when you add instructions to a custom form, we don't expose them as remarkup, so {Fxxx} references don't get attached correctly and won't get proper permissions.

Test Plan

Dragged-and-dropped an image into form instructions, saw the file attach to the form:

Screen Shot 2019-04-10 at 9.33.25 AM.png (499×650 px, 162 KB)

Diff Detail

Repository
rP Phabricator
Branch
remarkup1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22525
Build 30841: Run Core Tests
Build 30840: arc lint + arc unit