Page MenuHomePhabricator

Surface custom form instructions as a "Remarkup" field for the transaction layer
ClosedPublic

Authored by epriestley on Apr 10 2019, 4:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 1:53 AM
Unknown Object (File)
Wed, Mar 27, 1:53 AM
Unknown Object (File)
Wed, Mar 27, 1:53 AM
Unknown Object (File)
Sat, Mar 16, 11:03 AM
Unknown Object (File)
Fri, Mar 1, 5:03 AM
Unknown Object (File)
Feb 21 2024, 1:13 PM
Unknown Object (File)
Feb 14 2024, 4:30 AM
Unknown Object (File)
Feb 3 2024, 10:03 PM
Subscribers
None
Tokens
"Love" token, awarded by amckinley.

Details

Summary

Ref T13263. See https://discourse.phabricator-community.org/t/image-uploads-for-forms-too-restricted-by-default/2594. Currently, when you add instructions to a custom form, we don't expose them as remarkup, so {Fxxx} references don't get attached correctly and won't get proper permissions.

Test Plan

Dragged-and-dropped an image into form instructions, saw the file attach to the form:

Screen Shot 2019-04-10 at 9.33.25 AM.png (499×650 px, 162 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable