Page MenuHomePhabricator

Surface custom form instructions as a "Remarkup" field for the transaction layer
ClosedPublic

Authored by epriestley on Apr 10 2019, 4:37 PM.
Tags
None
Referenced Files
F13323459: D20387.id48654.diff
Fri, Jun 14, 6:46 PM
F13320683: D20387.diff
Fri, Jun 14, 5:52 AM
F13309600: D20387.diff
Mon, Jun 10, 10:23 AM
F13260988: D20387.id48650.diff
Mon, May 27, 12:37 AM
F13252010: D20387.diff
Sat, May 25, 12:59 AM
F13244405: D20387.id48650.diff
Thu, May 23, 4:47 AM
F13236751: D20387.diff
Tue, May 21, 10:48 AM
F13203923: D20387.diff
May 15 2024, 12:13 AM
Subscribers
None
Tokens
"Love" token, awarded by amckinley.

Details

Summary

Ref T13263. See https://discourse.phabricator-community.org/t/image-uploads-for-forms-too-restricted-by-default/2594. Currently, when you add instructions to a custom form, we don't expose them as remarkup, so {Fxxx} references don't get attached correctly and won't get proper permissions.

Test Plan

Dragged-and-dropped an image into form instructions, saw the file attach to the form:

Screen Shot 2019-04-10 at 9.33.25 AM.png (499×650 px, 162 KB)

Diff Detail

Repository
rP Phabricator
Branch
remarkup1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22525
Build 30841: Run Core Tests
Build 30840: arc lint + arc unit