Differential D20334

Give Dashboard query panels a more obvious "View All" button
ClosedPublic
Actions

Authored by epriestley on Mar 27 2019, 3:28 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rP6b069f26c081: Give Dashboard query panels a more obvious "View All" button

Summary

Depends on D20333. Ref T13272. Currently, dashboard query panels have an aesthetic but hard-to-see icon to view results, with no text label.

Instead, provide an easier-to-see button with a text label.

Test Plan

Screen Shot 2019-03-27 at 8.25.59 AM.png (259×808 px, 39 KB)

Diff Detail

Repository

rP Phabricator

Branch

panel2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22401
Build 30650: Run Core Tests
Build 30649: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 27 2019, 3:28 PM

Harbormaster completed remote builds in B22401: Diff 48530.Mar 27 2019, 3:30 PM

epriestley requested review of this revision.Mar 27 2019, 3:30 PM

epriestley added a child revision: D20335: When query panels overheat, degrade them and show a warning.Mar 27 2019, 3:45 PM

amckinley accepted this revision.Mar 27 2019, 9:25 PM

This revision is now accepted and ready to land.Mar 27 2019, 9:25 PM

Closed by commit rP6b069f26c081: Give Dashboard query panels a more obvious "View All" button (authored by epriestley). · Explain WhyMar 27 2019, 10:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

paneltype/

PhabricatorDashboardQueryPanelType.php

14 lines

Diff 48530

View Options

src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php

Give Dashboard query panels a more obvious "View All" buttonClosedPublicActions