Differential D20314

Fix two minor timezone display issues
ClosedPublic
Actions

Authored by epriestley on Mar 22 2019, 10:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Feb 14, 8:04 PM

	Unknown Object (File)
	Sun, Feb 2, 10:12 AM

	Unknown Object (File)
	Sat, Jan 25, 2:35 AM

	Unknown Object (File)
	Wed, Jan 22, 2:04 AM

	Unknown Object (File)
	Tue, Jan 21, 10:33 AM

	Unknown Object (File)
	Jan 17 2025, 5:41 PM

	Unknown Object (File)
	Dec 19 2024, 1:04 AM

	Unknown Object (File)
	Dec 17 2024, 6:24 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13263: Plans: 2019 Week 11-15 Bonus Content

Commits

rP1d73ae3b50a6: Fix two minor timezone display issues

Summary

Ref T13263. Two minor issues:

The "reconcile" dialog shows the wrong sign because JS signs differ from normal signs (for example, PST or PDT or whatever we're in right now is shown as "UTC+7", but should be "UTC-7").
The big dropdown of possible timezones lumps "UTC+X:30" timezones into "UTC+X".

Test Plan

Reconciled "America/Nome", saw negative UTC offsets for "America/Nome" and "America/Los_Angeles" (previously: improperly positive).
Viewed the big timzone list, saw ":30" and ":45" timezones grouped/labeled more accurately.

Diff Detail

Repository

Branch

tz1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22332
Build 30556: Run Core Tests
Build 30555: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 22 2019, 10:07 PM

Harbormaster completed remote builds in B22332: Diff 48468.Mar 22 2019, 10:09 PM

epriestley requested review of this revision.Mar 22 2019, 10:09 PM

amckinley accepted this revision.Mar 25 2019, 5:37 PM

This revision is now accepted and ready to land.Mar 25 2019, 5:37 PM

Closed by commit rP1d73ae3b50a6: Fix two minor timezone display issues (authored by epriestley). · Explain WhyMar 25 2019, 5:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

controller/

PhabricatorSettingsTimezoneController.php

5 lines

setting/

PhabricatorTimezoneSetting.php

13 lines

Diff 48468

src/applications/settings/controller/PhabricatorSettingsTimezoneController.php

Loading...

src/applications/settings/setting/PhabricatorTimezoneSetting.php

Loading...