Differential D20218

Provide "harbormaster.buildplan.edit" in the API
ClosedPublic
Actions

Authored by epriestley on Feb 26 2019, 1:23 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc)

Commits

rP8338f940573c: Provide "harbormaster.buildplan.edit" in the API

Summary

Depends on D20217. Ref T13258. Mostly for completeness. You can't edit build steps so this may not be terribly useful, but you can do bulk policy edits or whatever?

Test Plan

Edited a build plan via API.

Diff Detail

Repository

rP Phabricator

Branch

harbor3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22129
Build 30235: Run Core Tests
Build 30234: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 26 2019, 1:23 PM

Owners added a subscriber: Restricted Owners Package.Feb 26 2019, 1:23 PM

epriestley edited the summary of this revision. (Show Details)Feb 26 2019, 1:24 PM

epriestley added a task: T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc).

Harbormaster completed remote builds in B22129: Diff 48267.Feb 26 2019, 1:25 PM

epriestley requested review of this revision.Feb 26 2019, 1:25 PM

epriestley added a child revision: D20219: Add a "Recent Builds" element to the Build Plan UI and tighten up a few odds and ends.Feb 26 2019, 1:49 PM

amckinley accepted this revision.Feb 27 2019, 12:52 AM

This revision is now accepted and ready to land.Feb 27 2019, 12:52 AM

Closed by commit rP8338f940573c: Provide "harbormaster.buildplan.edit" in the API (authored by epriestley). · Explain WhyFeb 28 2019, 3:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

harbormaster/

conduit/

HarbormasterBuildPlanEditAPIMethod.php

20 lines

Diff 48267

View Options

src/__phutil_library_map__.php