Paths

Table of Contentst

Differential D20154

Replace all "setQueryParam()" calls with "remove/replaceQueryParam()"
ClosedPublic
Actions

Authored by epriestley on Feb 12 2019, 9:38 PM.

Tags

None

Referenced Files

	F14412547: D20154.diff
	Tue, Dec 24, 1:07 PM

	Unknown Object (File)
	Sun, Dec 8, 1:20 PM

	Unknown Object (File)
	Wed, Dec 4, 11:02 PM

	Unknown Object (File)
	Nov 14 2024, 4:14 AM

	Unknown Object (File)
	Nov 8 2024, 5:29 AM

	Unknown Object (File)
	Oct 27 2024, 2:29 AM

	Unknown Object (File)
	Oct 25 2024, 8:38 PM

	Unknown Object (File)
	Oct 25 2024, 1:40 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules

Commits

rP5892c7898603: Replace all "setQueryParam()" calls with "remove/replaceQueryParam()"

Summary

Ref T13250. See D20149. Mostly: clarify semantics. Partly: remove magic "null" behavior.

Test Plan

Poked around, but mostly just inspection since these are pretty much one-for-one.

Diff Detail

Repository

Branch

uri5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21964
Build 29997: Run Core Tests
Build 29996: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 12 2019, 9:38 PM

Herald added a subscriber: yelirekim. · View Herald TranscriptFeb 12 2019, 9:38 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 12 2019, 9:39 PM

Harbormaster failed remote builds in B21964: Diff 48120!

Depends on D20149. In the cases where the second parameter is a variable, there's some possibility that it's sometimes null in some tricky case, although I've tried to look through all the callsites and catch any of this. If this is the case, we'll get an explicit exception shortly ("second parameter to replace must not be null").

epriestley requested review of this revision.Feb 12 2019, 9:42 PM

amckinley accepted this revision.Feb 14 2019, 7:42 PM

This revision is now accepted and ready to land.Feb 14 2019, 7:42 PM

Closed by commit rP5892c7898603: Replace all "setQueryParam()" calls with "remove/replaceQueryParam()" (authored by epriestley). · Explain WhyFeb 14 2019, 7:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

aphront/

AphrontRequest.php

2 lines

applications/

almanac/

controller/

AlmanacController.php

2 lines

auth/

controller/

PhabricatorAuthController.php

2 lines

PhabricatorAuthStartController.php

4 lines

config/

PhabricatorAuthNewController.php

2 lines

mfa/

PhabricatorAuthFactorProviderEditController.php

2 lines

extension/

PhabricatorAuthMainMenuBarExtension.php

2 lines

calendar/

controller/

PhabricatorCalendarImportViewController.php

6 lines

config/

check/

PhabricatorWebServerSetupCheck.php

2 lines

conpherence/

controller/

ConpherenceViewController.php

2 lines

dashboard/

engine/

PhabricatorDashboardPanelRenderingEngine.php

4 lines

PhabricatorDashboardRenderingEngine.php

6 lines

differential/

controller/

DifferentialDiffCreateController.php

2 lines

fact/

controller/

PhabricatorFactHomeController.php

2 lines

files/

controller/

PhabricatorFileLightboxController.php

2 lines

PhabricatorFileTransformListController.php

2 lines

markup/

PhabricatorImageRemarkupRule.php

2 lines

maniphest/

controller/

ManiphestTaskDetailController.php

6 lines

ManiphestTaskSubtaskController.php

6 lines

view/

ManiphestTaskListView.php

2 lines

multimeter/

controller/

MultimeterSampleController.php

6 lines

notification/

client/

PhabricatorNotificationServerRef.php

2 lines

controller/

PhabricatorNotificationPanelController.php

2 lines

query/

PhabricatorNotificationSearchEngine.php

2 lines

oauthserver/

PhabricatorOAuthResponse.php

2 lines

controller/

PhabricatorOAuthServerAuthController.php

2 lines

pholio/

view/

PholioMockImagesView.php

2 lines

phortune/

controller/

payment/

PhortunePaymentMethodCreateController.php

2 lines

subscription/

PhortuneSubscriptionEditController.php

4 lines

ponder/

view/

PonderAddAnswerView.php

2 lines

project/

controller/

PhabricatorProjectBoardViewController.php

30 lines

PhabricatorProjectColumnHideController.php

2 lines

PhabricatorProjectDefaultController.php

2 lines

releeph/

controller/

request/

ReleephRequestDifferentialCreateController.php

2 lines

search/

controller/

PhabricatorApplicationSearchController.php

4 lines

settings/

panel/

PhabricatorMultiFactorSettingsPanel.php

2 lines

transactions/

view/

PhabricatorApplicationTransactionCommentView.php

2 lines

typeahead/

controller/

PhabricatorTypeaheadModularDatasourceController.php

12 lines

infrastructure/

env/

PhabricatorEnv.php

16 lines

view/

phui/

PHUITimelineView.php

4 lines

Diff 48120

src/aphront/AphrontRequest.php

Loading...

src/applications/almanac/controller/AlmanacController.php

Loading...

src/applications/auth/controller/PhabricatorAuthController.php

Loading...

src/applications/auth/controller/PhabricatorAuthStartController.php

Loading...

src/applications/auth/controller/config/PhabricatorAuthNewController.php

Loading...

src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderEditController.php

Loading...

src/applications/auth/extension/PhabricatorAuthMainMenuBarExtension.php

Loading...

src/applications/calendar/controller/PhabricatorCalendarImportViewController.php

Loading...

src/applications/config/check/PhabricatorWebServerSetupCheck.php

Loading...

src/applications/conpherence/controller/ConpherenceViewController.php

Loading...

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...

src/applications/dashboard/engine/PhabricatorDashboardRenderingEngine.php

Loading...

src/applications/differential/controller/DifferentialDiffCreateController.php

Loading...

src/applications/fact/controller/PhabricatorFactHomeController.php

Loading...

src/applications/files/controller/PhabricatorFileLightboxController.php

Loading...

src/applications/files/controller/PhabricatorFileTransformListController.php

Loading...

src/applications/files/markup/PhabricatorImageRemarkupRule.php

Loading...

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...

src/applications/maniphest/controller/ManiphestTaskSubtaskController.php

Loading...

src/applications/maniphest/view/ManiphestTaskListView.php

Loading...

src/applications/multimeter/controller/MultimeterSampleController.php

Loading...

src/applications/notification/client/PhabricatorNotificationServerRef.php

Loading...

src/applications/notification/controller/PhabricatorNotificationPanelController.php

Loading...

src/applications/notification/query/PhabricatorNotificationSearchEngine.php

Loading...

src/applications/oauthserver/PhabricatorOAuthResponse.php

Loading...

src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php

Loading...

src/applications/pholio/view/PholioMockImagesView.php

Loading...

src/applications/phortune/controller/payment/PhortunePaymentMethodCreateController.php

Loading...

src/applications/phortune/controller/subscription/PhortuneSubscriptionEditController.php

Loading...

src/applications/ponder/view/PonderAddAnswerView.php

Loading...

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...

src/applications/project/controller/PhabricatorProjectColumnHideController.php

Loading...

src/applications/project/controller/PhabricatorProjectDefaultController.php

Loading...

src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php

Loading...

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...

src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php

Loading...

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Loading...

src/infrastructure/env/PhabricatorEnv.php

Loading...

src/view/phui/PHUITimelineView.php

Loading...