HomePhabricator
Diffusion Phabricator 5892c7898603

Replace all "setQueryParam()" calls with "remove/replaceQueryParam()"
5892c7898603
Actions

Description

Replace all "setQueryParam()" calls with "remove/replaceQueryParam()"

Summary: Ref T13250. See D20149. Mostly: clarify semantics. Partly: remove magic "null" behavior.

Test Plan: Poked around, but mostly just inspection since these are pretty much one-for-one.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: yelirekim

Maniphest Tasks: T13250

Differential Revision: https://secure.phabricator.com/D20154

Details

Provenance
epriestleyAuthored on Feb 12 2019, 9:35 PM
epriestleyPushed on Feb 14 2019, 7:56 PM
Reviewer
amckinley
Differential Revision
D20154: Replace all "setQueryParam()" calls with "remove/replaceQueryParam()"
Parents
rP241f06c9ffc6: Clean up final `setQueryParams()` callsites
Branches
Unknown
Tags
Unknown
Tasks
T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules
Build Status
Buildable 22005
Build 30058: Run Core Tests

Changes (40)

PathSize
src/
aphront/
applications/
almanac/
controller/
auth/
controller/
config/
mfa/
extension/
calendar/
controller/
config/
check/
conpherence/
controller/
dashboard/
engine/
differential/
controller/
fact/
controller/
files/
controller/
markup/
maniphest/
controller/
view/
multimeter/
controller/
notification/
client/
controller/
query/
oauthserver/
controller/
pholio/
view/
phortune/
controller/
payment/
subscription/
ponder/
view/
project/
controller/
releeph/
controller/
request/
search/
controller/
settings/
panel/
transactions/
view/
typeahead/
controller/
infrastructure/
env/
view/
phui/

rP5892c7898603

View Options

src/aphront/AphrontRequest.php

Loading...
View Options

src/applications/almanac/controller/AlmanacController.php

Loading...
View Options

src/applications/auth/controller/PhabricatorAuthController.php

Loading...
View Options

src/applications/auth/controller/PhabricatorAuthStartController.php

Loading...
View Options

src/applications/auth/controller/config/PhabricatorAuthNewController.php

Loading...
View Options

src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderEditController.php

Loading...
View Options

src/applications/auth/extension/PhabricatorAuthMainMenuBarExtension.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarImportViewController.php

Loading...
View Options

src/applications/config/check/PhabricatorWebServerSetupCheck.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceViewController.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardRenderingEngine.php

Loading...
View Options

src/applications/differential/controller/DifferentialDiffCreateController.php

Loading...
View Options

src/applications/fact/controller/PhabricatorFactHomeController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileLightboxController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileTransformListController.php

Loading...
View Options

src/applications/files/markup/PhabricatorImageRemarkupRule.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskSubtaskController.php

Loading...
View Options

src/applications/maniphest/view/ManiphestTaskListView.php

Loading...
View Options

src/applications/multimeter/controller/MultimeterSampleController.php

Loading...
View Options

src/applications/notification/client/PhabricatorNotificationServerRef.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationPanelController.php

Loading...
View Options

src/applications/notification/query/PhabricatorNotificationSearchEngine.php

Loading...
View Options

src/applications/oauthserver/PhabricatorOAuthResponse.php

Loading...
View Options

src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php

Loading...
View Options

src/applications/pholio/view/PholioMockImagesView.php

Loading...
View Options

src/applications/phortune/controller/payment/PhortunePaymentMethodCreateController.php

Loading...
View Options

src/applications/phortune/controller/subscription/PhortuneSubscriptionEditController.php

Loading...
View Options

src/applications/ponder/view/PonderAddAnswerView.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectColumnHideController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectDefaultController.php

Loading...
View Options

src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php

Loading...
View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
View Options

src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Loading...
View Options

src/infrastructure/env/PhabricatorEnv.php

Loading...
View Options

src/view/phui/PHUITimelineView.php

Loading...
Phabricator · Built by Phacility