Details
Details
Poked around, but mostly just inspection since these are pretty much one-for-one.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Depends on D20149. In the cases where the second parameter is a variable, there's some possibility that it's sometimes null in some tricky case, although I've tried to look through all the callsites and catch any of this. If this is the case, we'll get an explicit exception shortly ("second parameter to replace must not be null").