Page MenuHomePhabricator

Fix a remarkup rule for `[x](y)` links when "y" is the empty string
ClosedPublic

Authored by epriestley on Feb 11 2019, 9:26 PM.
Tags
None
Referenced Files
F15345146: D20144.diff
Mon, Mar 10, 8:49 AM
Unknown Object (File)
Mon, Feb 24, 2:30 AM
Unknown Object (File)
Feb 4 2025, 12:25 AM
Unknown Object (File)
Feb 2 2025, 8:36 AM
Unknown Object (File)
Jan 30 2025, 3:42 AM
Unknown Object (File)
Jan 26 2025, 7:50 PM
Unknown Object (File)
Jan 26 2025, 7:50 PM
Unknown Object (File)
Jan 26 2025, 7:50 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/uninitialized-string-offset-error-in-phutilremarkupdocumentlinkrule/2379. This test is incorrect (should be against $uri, not $uri[0]) and should happen before we access $uri[0]).

Test Plan
  • Entered [x](), no more error in the logs.
  • Entered [x](http://example.com), got a link.

Diff Detail

Repository
rPHU libphutil
Branch
remark1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21927
Build 29942: Run Core Tests
Build 29941: arc lint + arc unit