Page MenuHomePhabricator

Fix a remarkup rule for `[x](y)` links when "y" is the empty string
ClosedPublic

Authored by epriestley on Feb 11 2019, 9:26 PM.
Tags
None
Referenced Files
F18770889: D20144.id48088.diff
Wed, Oct 8, 3:55 PM
F17777398: D20144.diff
Jul 24 2025, 12:24 AM
Unknown Object (File)
May 5 2025, 11:50 AM
Unknown Object (File)
May 5 2025, 11:50 AM
Unknown Object (File)
Apr 27 2025, 7:17 PM
Unknown Object (File)
Apr 27 2025, 7:17 PM
Unknown Object (File)
Apr 27 2025, 7:17 PM
Unknown Object (File)
Apr 27 2025, 7:17 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/uninitialized-string-offset-error-in-phutilremarkupdocumentlinkrule/2379. This test is incorrect (should be against $uri, not $uri[0]) and should happen before we access $uri[0]).

Test Plan
  • Entered [x](), no more error in the logs.
  • Entered [x](http://example.com), got a link.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable