Page MenuHomePhabricator

Fix a remarkup rule for `[x](y)` links when "y" is the empty string
ClosedPublic

Authored by epriestley on Feb 11 2019, 9:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 3, 11:59 AM
Unknown Object (File)
Tue, Mar 26, 2:35 AM
Unknown Object (File)
Mon, Mar 25, 8:38 AM
Unknown Object (File)
Mon, Mar 25, 8:38 AM
Unknown Object (File)
Mon, Mar 25, 8:38 AM
Unknown Object (File)
Feb 16 2024, 5:09 PM
Unknown Object (File)
Feb 15 2024, 7:20 PM
Unknown Object (File)
Feb 14 2024, 12:36 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/uninitialized-string-offset-error-in-phutilremarkupdocumentlinkrule/2379. This test is incorrect (should be against $uri, not $uri[0]) and should happen before we access $uri[0]).

Test Plan
  • Entered [x](), no more error in the logs.
  • Entered [x](http://example.com), got a link.

Diff Detail

Repository
rPHU libphutil
Branch
remark1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21927
Build 29942: Run Core Tests
Build 29941: arc lint + arc unit