HomePhabricator

Fix a remarkup rule for `[x](y)` links when "y" is the empty string

Description

Fix a remarkup rule for [x](y) links when "y" is the empty string

Summary: See https://discourse.phabricator-community.org/t/uninitialized-string-offset-error-in-phutilremarkupdocumentlinkrule/2379. This test is incorrect (should be against $uri, not $uri[0]) and should happen before we access $uri[0]).

Test Plan:

  • Entered [x](), no more error in the logs.
  • Entered [x](http://example.com), got a link.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20144

Details

Provenance
epriestleyAuthored on Feb 11 2019, 9:24 PM
epriestleyPushed on Feb 11 2019, 11:09 PM
Reviewer
amckinley
Differential Revision
D20144: Fix a remarkup rule for `[x](y)` links when "y" is the empty string
Parents
rPHUbbd53c622271: Introduce "phutil_string_cast()" to work around interesting choices in "…
Branches
Unknown
Tags
Unknown
Build Status
Buildable 21941
Build 29961: Run Core Tests