Use "phutil_string_cast()" in TypeaheadDatasource
ClosedPublic
Actions

Authored by epriestley on Feb 11 2019, 6:51 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules

Commits

rP1275326ea6b6: Use "phutil_string_cast()" in TypeaheadDatasource

Summary

Depends on D20138. Ref T13250. This improves exception behavior and gives us a standard page with a stack trace instead of a text fatal with no stack trace.

Truly a great day for PHP.

(Eventually we may want to replace all (string) with phutil_string_cast(), but let's let it have some time in the wild first?)

Test Plan

Triggered the error, got a more useful exception behavior.

Diff Detail

Repository

rP Phabricator

Branch

throwable3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21920
Build 29929: Run Core Tests
Build 29928: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 11 2019, 6:51 PM

Harbormaster completed remote builds in B21920: Diff 48081.Feb 11 2019, 6:53 PM

epriestley requested review of this revision.Feb 11 2019, 6:53 PM

epriestley added a child revision: D20142: Let the top-level exception handler dump a stack trace if we reach debug mode before things go sideways.Feb 11 2019, 9:10 PM

amckinley accepted this revision.Feb 11 2019, 9:35 PM

This revision is now accepted and ready to land.Feb 11 2019, 9:35 PM

Closed by commit rP1275326ea6b6: Use "phutil_string_cast()" in TypeaheadDatasource (authored by epriestley). · Explain WhyFeb 11 2019, 10:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

typeahead/

datasource/

PhabricatorTypeaheadDatasource.php

4 lines

Diff 48081

View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php

Use "phutil_string_cast()" in TypeaheadDatasourceClosedPublicActions