Page MenuHomePhabricator

Use "phutil_string_cast()" in TypeaheadDatasource
ClosedPublic

Authored by epriestley on Feb 11 2019, 6:51 PM.
Tags
None
Referenced Files
F15481560: D20140.id48081.diff
Tue, Apr 8, 9:46 PM
F15475987: D20140.id48094.diff
Mon, Apr 7, 2:05 AM
F15475501: D20140.id48094.diff
Sun, Apr 6, 8:01 PM
F15471312: D20140.id.diff
Sat, Apr 5, 4:28 AM
F15469744: D20140.diff
Fri, Apr 4, 4:06 PM
F15414691: D20140.id.diff
Thu, Mar 20, 1:57 AM
F15349270: D20140.diff
Mar 10 2025, 2:53 PM
F15284513: D20140.diff
Mar 4 2025, 9:54 AM
Subscribers
None

Details

Summary

Depends on D20138. Ref T13250. This improves exception behavior and gives us a standard page with a stack trace instead of a text fatal with no stack trace.

Truly a great day for PHP.

(Eventually we may want to replace all (string) with phutil_string_cast(), but let's let it have some time in the wild first?)

Test Plan

Triggered the error, got a more useful exception behavior.

Diff Detail

Repository
rP Phabricator
Branch
throwable3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21920
Build 29929: Run Core Tests
Build 29928: arc lint + arc unit