Page MenuHomePhabricator
Differential D20114

Revert "feed.http-hooks" HTTP request construction to use "http_build_query()" so nested "storyData" is handled correctly
ClosedPublic
Actions

Authored by epriestley on Feb 7 2019, 12:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 5:59 AM
Unknown Object (File)
Mon, Dec 16, 12:40 AM
Unknown Object (File)
Tue, Dec 10, 4:31 PM
Unknown Object (File)
Thu, Dec 5, 7:37 PM
Unknown Object (File)
Mon, Dec 2, 3:29 PM
Unknown Object (File)
Thu, Nov 28, 4:06 AM
Unknown Object (File)
Wed, Nov 27, 7:32 AM
Unknown Object (File)
Nov 24 2024, 2:24 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPe25dc2dfe283: Revert "feed.http-hooks" HTTP request construction to use "http_build_query()"…
Summary

See https://discourse.phabricator-community.org/t/storydata-is-blank-in-outgoing-requests-to-the-configured-feed-http-hooks/2366/.

This behavior was changed by D20049. I think it's generally good that we not accept/encode nested values in a PHP-specific way, but retain feed.http-hooks compatibility for now.

Test Plan

Screen Shot 2019-02-06 at 4.17.27 PM.png (1×1 px, 360 KB)

Diff Detail

Repository
rP Phabricator
Branch
hook1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21866
Build 29843: Run Core Tests
Build 29842: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
feed/
worker/
5 lines

Diff 48026

View Options

src/applications/feed/worker/FeedPublisherHTTPWorker.php

Loading...
Phabricator · Built by Phacility