Page MenuHomePhabricator

Revert "feed.http-hooks" HTTP request construction to use "http_build_query()" so nested "storyData" is handled correctly
ClosedPublic

Authored by epriestley on Feb 7 2019, 12:19 AM.
Tags
None
Referenced Files
F15374270: D20114.diff
Wed, Mar 12, 6:06 PM
F15345806: D20114.id48026.diff
Mon, Mar 10, 12:34 PM
F15340726: D20114.diff
Sun, Mar 9, 4:24 PM
Unknown Object (File)
Mon, Feb 24, 2:30 AM
Unknown Object (File)
Feb 9 2025, 7:07 AM
Unknown Object (File)
Feb 9 2025, 7:07 AM
Unknown Object (File)
Feb 9 2025, 7:07 AM
Unknown Object (File)
Feb 4 2025, 10:25 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/storydata-is-blank-in-outgoing-requests-to-the-configured-feed-http-hooks/2366/.

This behavior was changed by D20049. I think it's generally good that we not accept/encode nested values in a PHP-specific way, but retain feed.http-hooks compatibility for now.

Test Plan

Screen Shot 2019-02-06 at 4.17.27 PM.png (1×1 px, 360 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable