Revert "feed.http-hooks" HTTP request construction to use "http_build_query()" so nested "storyData" is handled correctly
ClosedPublic
Actions

Authored by epriestley on Feb 7 2019, 12:19 AM.

Details

Reviewers

amckinley

Commits

rPe25dc2dfe283: Revert "feed.http-hooks" HTTP request construction to use "http_build_query()"…

Summary

See https://discourse.phabricator-community.org/t/storydata-is-blank-in-outgoing-requests-to-the-configured-feed-http-hooks/2366/.

This behavior was changed by D20049. I think it's generally good that we not accept/encode nested values in a PHP-specific way, but retain feed.http-hooks compatibility for now.

Test Plan

Screen Shot 2019-02-06 at 4.17.27 PM.png (1×1 px, 360 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 7 2019, 12:19 AM

Harbormaster completed remote builds in B21866: Diff 48026.Feb 7 2019, 12:21 AM

epriestley requested review of this revision.Feb 7 2019, 12:21 AM

epriestley added a child revision: D20115: Add formal setup guidance warning that "feed.http-hooks" will be removed in a future version of Phabricator.Feb 7 2019, 12:29 AM

epriestley mentioned this in D20116: Explicitly fail if `phutil_build_http_querystring()` is passed a map of nonscalars.Feb 7 2019, 12:34 AM

amckinley accepted this revision.Feb 7 2019, 8:23 PM

This revision is now accepted and ready to land.Feb 7 2019, 8:23 PM

Closed by commit rPe25dc2dfe283: Revert "feed.http-hooks" HTTP request construction to use "http_build_query()"… (authored by epriestley). · Explain WhyFeb 7 2019, 10:53 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rPHU24a884ce0b4d: Explicitly fail if `phutil_build_http_querystring()` is passed a map of….Feb 7 2019, 10:55 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

feed/

worker/

FeedPublisherHTTPWorker.php

5 lines

Diff 48054

View Options

src/applications/feed/worker/FeedPublisherHTTPWorker.php

Revert "feed.http-hooks" HTTP request construction to use "http_build_query()" so nested "storyData" is handled correctlyClosedPublicActions