Page MenuHomePhabricator
Differential D20114

Revert "feed.http-hooks" HTTP request construction to use "http_build_query()" so nested "storyData" is handled correctly
ClosedPublic
Actions

Authored by epriestley on Feb 7 2019, 12:19 AM.
Tags
None
Referenced Files
F18576836: D20114.diff
Wed, Sep 10, 4:55 PM
F18576766: D20114.diff
Wed, Sep 10, 4:32 PM
F18562061: D20114.diff
Tue, Sep 9, 2:07 AM
F18518019: D20114.diff
Fri, Sep 5, 2:22 PM
F18433050: D20114.id48054.diff
Sun, Aug 31, 7:19 AM
F18432257: D20114.diff
Sun, Aug 31, 6:24 AM
F18431998: D20114.id48054.diff
Sun, Aug 31, 5:57 AM
F18431338: D20114.id.diff
Sun, Aug 31, 5:08 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPe25dc2dfe283: Revert "feed.http-hooks" HTTP request construction to use "http_build_query()"…
Summary

See https://discourse.phabricator-community.org/t/storydata-is-blank-in-outgoing-requests-to-the-configured-feed-http-hooks/2366/.

This behavior was changed by D20049. I think it's generally good that we not accept/encode nested values in a PHP-specific way, but retain feed.http-hooks compatibility for now.

Test Plan

Screen Shot 2019-02-06 at 4.17.27 PM.png (1×1 px, 360 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
feed/
worker/
5 lines

Diff 48054

View Options

src/applications/feed/worker/FeedPublisherHTTPWorker.php

Loading...
Phabricator · Built by Phacility