Page MenuHomePhabricator

Revert "feed.http-hooks" HTTP request construction to use "http_build_query()" so nested "storyData" is handled correctly
ClosedPublic

Authored by epriestley on Feb 7 2019, 12:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 16 2024, 11:03 PM
Unknown Object (File)
Oct 16 2024, 12:12 PM
Unknown Object (File)
Sep 30 2024, 5:37 AM
Unknown Object (File)
Sep 25 2024, 8:19 PM
Unknown Object (File)
Sep 22 2024, 4:10 AM
Unknown Object (File)
Sep 16 2024, 1:11 PM
Unknown Object (File)
Sep 12 2024, 10:49 PM
Unknown Object (File)
Sep 12 2024, 8:56 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/storydata-is-blank-in-outgoing-requests-to-the-configured-feed-http-hooks/2366/.

This behavior was changed by D20049. I think it's generally good that we not accept/encode nested values in a PHP-specific way, but retain feed.http-hooks compatibility for now.

Test Plan

Screen Shot 2019-02-06 at 4.17.27 PM.png (1×1 px, 360 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable