Page MenuHomePhabricator

Revert "feed.http-hooks" HTTP request construction to use "http_build_query()" so nested "storyData" is handled correctly
ClosedPublic

Authored by epriestley on Feb 7 2019, 12:19 AM.
Tags
None
Referenced Files
F22876231: D20114.diff
Wed, Oct 14, 9:15 AM
F22727058: D20114.diff
Sun, Oct 4, 3:12 AM
Unknown Object (File)
Sep 1 2026, 3:22 PM
Unknown Object (File)
Aug 30 2026, 11:03 AM
Unknown Object (File)
Aug 29 2026, 3:26 PM
Unknown Object (File)
Jul 6 2026, 11:38 PM
Unknown Object (File)
Jul 1 2026, 12:25 AM
Unknown Object (File)
Jun 25 2026, 10:12 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/storydata-is-blank-in-outgoing-requests-to-the-configured-feed-http-hooks/2366/.

This behavior was changed by D20049. I think it's generally good that we not accept/encode nested values in a PHP-specific way, but retain feed.http-hooks compatibility for now.

Test Plan

Screen Shot 2019-02-06 at 4.17.27 PM.png (1×1 px, 360 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable