Page MenuHomePhabricator
Differential D20114

Revert "feed.http-hooks" HTTP request construction to use "http_build_query()" so nested "storyData" is handled correctly
ClosedPublic
Actions

Authored by epriestley on Feb 7 2019, 12:19 AM.
Tags
None
Referenced Files
F18854181: D20114.id48026.diff
Oct 31 2025, 10:08 PM
F18854171: D20114.id48026.diff
Oct 31 2025, 10:05 PM
F18850419: D20114.id48026.diff
Oct 30 2025, 4:42 PM
F18839654: D20114.id48054.diff
Oct 27 2025, 6:04 PM
F18797930: D20114.id48026.diff
Oct 17 2025, 5:38 AM
F18701168: D20114.id48054.diff
Sep 27 2025, 5:45 PM
F18682046: D20114.id.diff
Sep 26 2025, 5:10 AM
F18671873: D20114.diff
Sep 25 2025, 5:42 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPe25dc2dfe283: Revert "feed.http-hooks" HTTP request construction to use "http_build_query()"…
Summary

See https://discourse.phabricator-community.org/t/storydata-is-blank-in-outgoing-requests-to-the-configured-feed-http-hooks/2366/.

This behavior was changed by D20049. I think it's generally good that we not accept/encode nested values in a PHP-specific way, but retain feed.http-hooks compatibility for now.

Test Plan

Screen Shot 2019-02-06 at 4.17.27 PM.png (1×1 px, 360 KB)

Diff Detail

Repository
rP Phabricator
Branch
hook1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21866
Build 29843: Run Core Tests
Build 29842: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
feed/
worker/
5 lines

Diff 48026

View Options

src/applications/feed/worker/FeedPublisherHTTPWorker.php

Loading...
Phabricator · Built by Phacility