Page MenuHomePhabricator

In Owners Packages, make the API representation of the "Auditing" field more consistent
ClosedPublic

Authored by epriestley on Feb 5 2019, 3:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 1:49 PM
Unknown Object (File)
Mon, Dec 23, 7:42 AM
Unknown Object (File)
Mon, Dec 9, 10:25 AM
Unknown Object (File)
Thu, Dec 5, 5:22 PM
Unknown Object (File)
Nov 28 2024, 7:06 PM
Unknown Object (File)
Nov 26 2024, 6:58 PM
Unknown Object (File)
Nov 24 2024, 10:14 PM
Unknown Object (File)
Nov 22 2024, 1:40 AM
Subscribers
None

Details

Summary

Ref T13244. See PHI1047. A while ago, the "Review" field changed from "yes/no" to 20 flavors of "Non-Owner Blocking Under A Full Moon". The sky didn't fall, so we'll probably do this to "Audit" eventually too.

The "owners.search" API method anticipates this and returns "none" or "audit" to describe package audit statuses, so it can begin returning "audit-non-owner-reviewers" or whatever in the future.

However, the "owners.edit" API method doesn't work the same way, and takes strings, and the strings have to be numbers. This is goofy and confusing and generally bad.

Make "owners.edit" take the same strings that "owners.search" emits. For now, continue accepting the old values of "0" and "1".

Test Plan
  • Edited audit status of packages via API using "none", "audit", "0", "1" (worked), and invalid values like "quack" (helpful error).
  • Edited audit status of packages via web UI.
  • Used owners.search to retrieve package information.

Diff Detail

Repository
rP Phabricator
Branch
owners1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21821
Build 29773: Run Core Tests
Build 29772: arc lint + arc unit