Page MenuHomePhabricator

Prepare owners package audit rules to become more flexible
ClosedPublic

Authored by epriestley on Feb 7 2019, 4:19 PM.
Tags
None
Referenced Files
F18763294: D20124.id48043.diff
Mon, Oct 6, 11:39 PM
F18755792: D20124.id48042.diff
Sun, Oct 5, 7:24 AM
F18730832: D20124.id48065.diff
Tue, Sep 30, 1:39 PM
F18730024: D20124.diff
Tue, Sep 30, 12:06 PM
F18702544: D20124.id.diff
Sun, Sep 28, 12:34 AM
F18683678: D20124.id48043.diff
Fri, Sep 26, 8:06 AM
F18607134: D20124.diff
Sat, Sep 13, 11:19 PM
F18591449: D20124.diff
Fri, Sep 12, 9:15 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13244. See PHI1055. (Earlier, see D20091 and PHI1047.) Previously, we expanded the Owners package autoreview rules from "Yes/No" to several "Review (Blocking) If Non-Owner Author Not Subscribed via Package" kinds of rules. The sky didn't fall and this feature didn't turn into "Herald-in-Owners", so I'm comfortable doing something similar to the "Audit" rules.

PHI1055 is a request for a way to configure slightly different audit behavior, and expanding the options seems like a good approach to satisfy the use case.

Prepare to add more options by moving everything into a class that defines all the behavior of different states, and converting the "0/1" boolean column to a text column.

Test Plan
  • Created several packages, some with and some without auditing.
  • Inspected database for: package state; and associated transactions.
  • Ran the migrations.
  • Inspected database to confirm that state and transactions migrated correctly.
  • Reviewed transaction logs.
  • Created and edited packages and audit state.
  • Viewed the "Package List" element in Diffusion.
  • Pulled package information with owners.search, got sensible results.
  • Edited package audit status with owners.edit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable