Paths

Table of Contentst

Differential D20015

Adjust Google Auth Adapter to use Open ID Connect
AbandonedPublic
Actions

Authored by dragoon20 on Jan 23 2019, 9:11 AM.

Tags

None

Referenced Files

	F13184564: D20015.id47781.diff
	Fri, May 10, 8:26 PM

	F13182167: D20015.id47783.diff
	Thu, May 9, 8:25 PM

	F13176845: D20015.id.diff
	Wed, May 8, 5:48 PM

	F13175388: D20015.diff
	Wed, May 8, 4:55 AM

	Unknown Object (File)
	Tue, May 7, 6:16 AM

	Unknown Object (File)
	Sat, May 4, 4:11 PM

	Unknown Object (File)
	Fri, May 3, 3:56 AM

	Unknown Object (File)
	Mon, Apr 29, 4:05 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

Google planned to shutdown Google+ API because of
security vulnerabilities.

https://developers.google.com/+/api-shutdown

Test Plan

Locally, try to setup google authentication account and try login.

Diff Detail

Repository

Branch

adjust_google_sign_in

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21639
Build 29505: arc lint + arc unit

Event Timeline

dragoon20 created this revision.Jan 23 2019, 9:11 AM

Herald added 1 blocking reviewer(s): Blessed Reviewers. · View Herald TranscriptJan 23 2019, 9:11 AM

Herald added a subscriber: epriestley. · View Herald Transcript

dragoon20 requested review of this revision.Jan 23 2019, 9:11 AM

Harbormaster completed remote builds in B21637: Diff 47781.Jan 23 2019, 9:11 AM

Update some uncommitted code

Harbormaster completed remote builds in B21638: Diff 47783.Jan 23 2019, 9:14 AM

We'll ship a patch for this in the next release (see T13227) but this patch doesn't look quite right.

This is helpful as a starting point, but there are some related Auth changes I want to make at the same time (e.g., T5591) anyway.

src/auth/PhutilGoogleAuthAdapter.php
67	This looks wrong ("famiily" is misspelled).
152–177	This looks wrong, since the message is adjusted but the parameters are not, so the `%s` conversions won't line up.

This revision now requires changes to proceed.Jan 23 2019, 11:29 AM

Herald added a subscriber: Korvin. · View Herald TranscriptJan 23 2019, 11:29 AM

Fix typo and wrong parameter for error message

Harbormaster completed remote builds in B21639: Diff 47786.Jan 23 2019, 2:09 PM

Harbormaster completed remote builds in B21639: Diff 47786.

Hi @epriestley , thanks for looking at this patch, please help elaborate if there is something wrong with this patch.

Currently I only replace the use of access token to id token which is working.

As for T5591, maybe I can help you in another patch also, I am thinking that would need to add parameter on the login screen which resides in rP.

(See D20030.)

@epriestley thanks for the other diff, it worked, closing this diff

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

auth/

PhutilGoogleAuthAdapter.php

55 lines

PhutilOpenIDConnectAuthAdapter.php

17 lines

Diff 47786

src/__phutil_library_map__.php

Loading...

src/auth/PhutilGoogleAuthAdapter.php

Loading...

src/auth/PhutilOpenIDConnectAuthAdapter.php

Loading...