Page MenuHomePhabricator

Adjust Google Auth Adapter to use Open ID Connect
AbandonedPublic

Authored by dragoon20 on Jan 23 2019, 9:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 10:23 PM
Unknown Object (File)
Feb 7 2024, 11:01 AM
Unknown Object (File)
Feb 3 2024, 8:54 PM
Unknown Object (File)
Jan 25 2024, 1:45 AM
Unknown Object (File)
Dec 22 2023, 9:47 PM
Unknown Object (File)
Dec 22 2023, 5:52 PM
Unknown Object (File)
Dec 22 2023, 1:20 AM
Unknown Object (File)
Dec 21 2023, 8:57 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Google planned to shutdown Google+ API because of
security vulnerabilities.

https://developers.google.com/+/api-shutdown

Test Plan
  • Locally, try to setup google authentication account and try login.

Diff Detail

Repository
rPHU libphutil
Branch
adjust_google_sign_in
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21637
Build 29503: arc lint + arc unit

Event Timeline

Update some uncommitted code

We'll ship a patch for this in the next release (see T13227) but this patch doesn't look quite right.

This is helpful as a starting point, but there are some related Auth changes I want to make at the same time (e.g., T5591) anyway.

src/auth/PhutilGoogleAuthAdapter.php
63

This looks wrong ("famiily" is misspelled).

152–177

This looks wrong, since the message is adjusted but the parameters are not, so the %s conversions won't line up.

This revision now requires changes to proceed.Jan 23 2019, 11:29 AM

Fix typo and wrong parameter for error message

Hi @epriestley , thanks for looking at this patch, please help elaborate if there is something wrong with this patch.

Currently I only replace the use of access token to id token which is working.

As for T5591, maybe I can help you in another patch also, I am thinking that would need to add parameter on the login screen which resides in rP.

@epriestley thanks for the other diff, it worked, closing this diff