Paths

Table of Contentst

Differential D20015

Adjust Google Auth Adapter to use Open ID Connect
AbandonedPublic
Actions

Authored by dragoon20 on Jan 23 2019, 9:11 AM.

Tags

None

Referenced Files

	F15544081: D20015.id47786.diff
	Sat, Apr 26, 2:46 AM

	F15543840: D20015.id47783.diff
	Sat, Apr 26, 1:32 AM

	F15543516: D20015.id47786.diff
	Fri, Apr 25, 10:50 PM

	F15540120: D20015.id.diff
	Fri, Apr 25, 6:36 AM

	F15535815: D20015.diff
	Thu, Apr 24, 6:57 AM

	F15508098: D20015.id47786.diff
	Wed, Apr 16, 1:37 AM

	F15497029: D20015.id47783.diff
	Sun, Apr 13, 9:28 AM

	F15463882: D20015.id47781.diff
	Wed, Apr 2, 4:14 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

Google planned to shutdown Google+ API because of
security vulnerabilities.

https://developers.google.com/+/api-shutdown

Test Plan

Locally, try to setup google authentication account and try login.

Diff Detail

Repository

Branch

adjust_google_sign_in

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21638
Build 29504: arc lint + arc unit

Event Timeline

dragoon20 created this revision.Jan 23 2019, 9:11 AM

Herald added 1 blocking reviewer(s): Blessed Reviewers. · View Herald TranscriptJan 23 2019, 9:11 AM

Herald added a subscriber: epriestley. · View Herald Transcript

dragoon20 requested review of this revision.Jan 23 2019, 9:11 AM

Harbormaster completed remote builds in B21637: Diff 47781.Jan 23 2019, 9:11 AM

Update some uncommitted code

Harbormaster completed remote builds in B21638: Diff 47783.Jan 23 2019, 9:14 AM

We'll ship a patch for this in the next release (see T13227) but this patch doesn't look quite right.

This is helpful as a starting point, but there are some related Auth changes I want to make at the same time (e.g., T5591) anyway.

src/auth/PhutilGoogleAuthAdapter.php
67	This looks wrong ("famiily" is misspelled).
152–177	This looks wrong, since the message is adjusted but the parameters are not, so the `%s` conversions won't line up.

This revision now requires changes to proceed.Jan 23 2019, 11:29 AM

Herald added a subscriber: Korvin. · View Herald TranscriptJan 23 2019, 11:29 AM

Fix typo and wrong parameter for error message

Harbormaster completed remote builds in B21639: Diff 47786.Jan 23 2019, 2:09 PM

Harbormaster completed remote builds in B21639: Diff 47786.

Hi @epriestley , thanks for looking at this patch, please help elaborate if there is something wrong with this patch.

Currently I only replace the use of access token to id token which is working.

As for T5591, maybe I can help you in another patch also, I am thinking that would need to add parameter on the login screen which resides in rP.

(See D20030.)

@epriestley thanks for the other diff, it worked, closing this diff

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

auth/

PhutilGoogleAuthAdapter.php

53 lines

PhutilOpenIDConnectAuthAdapter.php

17 lines

Diff 47783

src/__phutil_library_map__.php

Loading...

src/auth/PhutilGoogleAuthAdapter.php

Loading...

src/auth/PhutilOpenIDConnectAuthAdapter.php

Loading...