Page MenuHomePhabricator

Update Google OAuth adapter to move away from deprecated "Google+" APIs
ClosedPublic

Authored by epriestley on Jan 25 2019, 1:48 AM.

Diff Detail

Repository
rPHU libphutil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 25 2019, 1:48 AM
epriestley requested review of this revision.Jan 25 2019, 1:49 AM
epriestley added inline comments.Jan 25 2019, 1:50 AM
src/auth/PhutilGoogleAuthAdapter.php
150

None of these instructions seem to make sense anymore and I suspect this "Enable Google+" error is now impossible. Fingers crossed until evidence surfaces to suggest otherwise.

dragoon20 accepted this revision.Jan 25 2019, 3:04 AM
dragoon20 added a subscriber: dragoon20.

I tested this and it works marvelous, thanks, waiting for the patch.

Macro lgtmacro:

This revision is now accepted and ready to land.Jan 25 2019, 3:04 AM
This revision was automatically updated to reflect the committed changes.
reed added a subscriber: reed.Feb 22 2019, 4:40 PM