Page MenuHomePhabricator
Differential D19921

Make the Pholio Mock "getImages" / "getAllImages" API more clear
ClosedPublic
Actions

Authored by epriestley on Dec 20 2018, 7:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 11:22 PM
Unknown Object (File)
Thu, Jan 30, 11:22 PM
Unknown Object (File)
Thu, Jan 30, 11:22 PM
Unknown Object (File)
Tue, Jan 28, 7:50 PM
Unknown Object (File)
Tue, Jan 28, 4:29 AM
Unknown Object (File)
Sat, Jan 25, 2:56 AM
Unknown Object (File)
Sat, Jan 25, 2:56 AM
Unknown Object (File)
Sat, Jan 25, 2:56 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T11351: Move Pholio to EditEngine and modern APIs
Commits
rP28989ac23145: Make the Pholio Mock "getImages" / "getAllImages" API more clear
Summary

Depends on D19920. Ref T11351. Currently, "images" and "all images" are attached to Mocks separately, and getImages() gets you only some images.

Clean this up slightly:

  • One attach method; attach everything.
  • Two getters, one for "images" (returns all images); one for "active images" (returns active images).
Test Plan

Browsed around Pholio without any apparent behavioral changes.

Diff Detail

Repository
rP Phabricator
Branch
pholio9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21399
Build 29142: Run Core Tests
Build 29141: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 20 2018, 7:48 PM
Harbormaster completed remote builds in B21399: Diff 47546.Dec 20 2018, 7:50 PM
epriestley requested review of this revision.Dec 20 2018, 7:50 PM
epriestley added inline comments.Dec 20 2018, 7:53 PM
src/applications/pholio/storage/PholioMock.php
121

This was a bug, should have asserted allImages instead.

epriestley added a child revision: D19922: Remove the onboard "mailKey" from Pholio Mocks.Dec 20 2018, 7:56 PM
amckinley accepted this revision.Dec 20 2018, 10:00 PM
This revision is now accepted and ready to land.Dec 20 2018, 10:00 PM
Closed by commit rP28989ac23145: Make the Pholio Mock "getImages" / "getAllImages" API more clear (authored by epriestley). · Explain WhyDec 20 2018, 11:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 47546

View Options

src/applications/pholio/controller/PholioMockCommentController.php

Loading...
View Options

src/applications/pholio/controller/PholioMockEditController.php

Loading...
View Options

src/applications/pholio/query/PholioMockQuery.php

Loading...
View Options

src/applications/pholio/query/PholioMockSearchEngine.php

Loading...
View Options

src/applications/pholio/storage/PholioMock.php

Loading...
View Options

src/applications/pholio/view/PholioMockEmbedView.php

Loading...
View Options

src/applications/pholio/view/PholioMockImagesView.php

Loading...
View Options

src/applications/pholio/view/PholioMockThumbGridView.php

Loading...
View Options

src/applications/pholio/view/PholioTransactionView.php

Loading...
View Options

src/applications/pholio/xaction/PholioImageFileTransaction.php

Loading...
Phabricator · Built by Phacility