Page MenuHomePhabricator

Un-implement MarkupInterface from Mocks and Images in Pholio
ClosedPublic

Authored by epriestley on Dec 18 2018, 11:41 PM.
Tags
None
Referenced Files
F15462236: D19912.id47527.diff
Tue, Apr 1, 1:14 PM
F15462235: D19912.id47532.diff
Tue, Apr 1, 1:14 PM
F15462234: D19912.id.diff
Tue, Apr 1, 1:14 PM
F15461934: D19912.id47528.diff
Tue, Apr 1, 12:27 PM
F15461885: D19912.diff
Tue, Apr 1, 12:09 PM
F15459200: D19912.id47527.diff
Mon, Mar 31, 10:53 AM
F15451562: D19912.id47527.diff
Fri, Mar 28, 10:43 PM
F15451230: D19912.id.diff
Fri, Mar 28, 8:53 PM
Subscribers
None

Details

Summary

Depends on D19911. Ref T11351. MarkupInterface has mostly been replaced with PHUIRemarkupView, and isn't really doing anything for us here. Get rid of it to simplify the code.

Test Plan

Viewed various mocks with descriptions and image descriptions, saw remarkup presented properly.

Diff Detail

Repository
rP Phabricator
Branch
pholio3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21382
Build 29115: Run Core Tests
Build 29114: arc lint + arc unit