Page MenuHomePhabricator

Un-implement MarkupInterface from Mocks and Images in Pholio
ClosedPublic

Authored by epriestley on Dec 18 2018, 11:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 11:57 AM
Unknown Object (File)
Thu, Mar 21, 8:06 AM
Unknown Object (File)
Feb 20 2024, 4:32 PM
Unknown Object (File)
Feb 3 2024, 8:28 PM
Unknown Object (File)
Feb 2 2024, 5:53 AM
Unknown Object (File)
Jan 25 2024, 1:39 AM
Unknown Object (File)
Jan 20 2024, 4:35 PM
Unknown Object (File)
Jan 16 2024, 5:39 PM
Subscribers
None

Details

Summary

Depends on D19911. Ref T11351. MarkupInterface has mostly been replaced with PHUIRemarkupView, and isn't really doing anything for us here. Get rid of it to simplify the code.

Test Plan

Viewed various mocks with descriptions and image descriptions, saw remarkup presented properly.

Diff Detail

Repository
rP Phabricator
Branch
pholio3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21381
Build 29113: Run Core Tests
Build 29112: arc lint + arc unit