Page MenuHomePhabricator
Differential D19912

Un-implement MarkupInterface from Mocks and Images in Pholio
ClosedPublic
Actions

Authored by epriestley on Dec 18 2018, 11:41 PM.
Tags
None
Referenced Files
F14370922: D19912.diff
Fri, Dec 20, 6:32 PM
Unknown Object (File)
Mon, Dec 2, 8:28 AM
Unknown Object (File)
Thu, Nov 21, 1:17 AM
Unknown Object (File)
Nov 13 2024, 7:46 AM
Unknown Object (File)
Nov 13 2024, 7:23 AM
Unknown Object (File)
Nov 6 2024, 7:04 PM
Unknown Object (File)
Oct 31 2024, 12:24 AM
Unknown Object (File)
Oct 9 2024, 11:03 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T11351: Move Pholio to EditEngine and modern APIs
Commits
rPc4c5d8a21093: Un-implement MarkupInterface from Mocks and Images in Pholio
Summary

Depends on D19911. Ref T11351. MarkupInterface has mostly been replaced with PHUIRemarkupView, and isn't really doing anything for us here. Get rid of it to simplify the code.

Test Plan

Viewed various mocks with descriptions and image descriptions, saw remarkup presented properly.

Diff Detail

Repository
rP Phabricator
Branch
pholio3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21381
Build 29113: Run Core Tests
Build 29112: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
pholio/
controller/
7 lines
storage/
26 lines
36 lines
view/
16 lines

Diff 47527

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/pholio/controller/PholioMockViewController.php

Loading...
View Options

src/applications/pholio/storage/PholioImage.php

Loading...
View Options

src/applications/pholio/storage/PholioMock.php

Loading...
View Options

src/applications/pholio/view/PholioMockImagesView.php

Loading...
Phabricator · Built by Phacility