Page MenuHomePhabricator
Differential D19856

Give "Autoclose Only" repository detail proper getters/setters
ClosedPublic
Actions

Authored by epriestley on Dec 10 2018, 3:50 PM.
Tags
None
Referenced Files
F13167054: D19856.diff
Tue, May 7, 6:54 AM
Unknown Object (File)
Sun, May 5, 9:37 AM
Unknown Object (File)
Fri, May 3, 4:32 AM
Unknown Object (File)
Mon, Apr 29, 10:04 PM
Unknown Object (File)
Mon, Apr 29, 6:17 PM
Unknown Object (File)
Thu, Apr 25, 12:36 AM
Unknown Object (File)
Thu, Apr 18, 5:20 PM
Unknown Object (File)
Thu, Apr 11, 8:29 AM
View All 87 Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13222: 2018 Week 48-51 Bonus Content
Commits
rPc3206476a303: Give "Autoclose Only" repository detail proper getters/setters
Summary

Ref T13222. See D19829. We're inconsistent about using getDetail()/setDetail() to do some ad-hoc reads. Put this stuff in proper accessor methods.

Also a couple of text fixes from D19850.

Test Plan

Set, edited, and removed autoclose branches from a repository. Got sensible persistence and rendering behavior.

Diff Detail

Repository
rP Phabricator
Branch
detail1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21270
Build 28934: Run Core Tests
Build 28933: arc lint + arc unit

Revision Contents
Changeset List

Diff 47417

View Options

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementThawWorkflow.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/xaction/PhabricatorRepositoryAutocloseOnlyTransaction.php

Loading...
Phabricator · Built by Phacility