Paths

Table of Contentst

Differential D19856

Give "Autoclose Only" repository detail proper getters/setters
ClosedPublic
Actions

Authored by epriestley on Dec 10 2018, 3:50 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13222: 2018 Week 48-51 Bonus Content

Commits

rPc3206476a303: Give "Autoclose Only" repository detail proper getters/setters

Summary

Ref T13222. See D19829. We're inconsistent about using getDetail()/setDetail() to do some ad-hoc reads. Put this stuff in proper accessor methods.

Also a couple of text fixes from D19850.

Test Plan

Set, edited, and removed autoclose branches from a repository. Got sensible persistence and rendering behavior.

Diff Detail

Repository

rP Phabricator

Branch

detail1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21270
Build 28934: Run Core Tests
Build 28933: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 10 2018, 3:50 PM

Harbormaster completed remote builds in B21270: Diff 47417.Dec 10 2018, 3:52 PM

epriestley requested review of this revision.Dec 10 2018, 3:52 PM

epriestley added a child revision: D19857: Give "Track Only" repository detail proper getters/setters.Dec 10 2018, 4:06 PM

epriestley mentioned this in T13222: 2018 Week 48-51 Bonus Content.Dec 10 2018, 4:09 PM

amckinley accepted this revision.Dec 10 2018, 6:21 PM

This revision is now accepted and ready to land.Dec 10 2018, 6:21 PM

Closed by commit rPc3206476a303: Give "Autoclose Only" repository detail proper getters/setters (authored by epriestley). · Explain WhyDec 10 2018, 6:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

editor/

DiffusionRepositoryEditEngine.php

3 lines

management/

DiffusionRepositoryBranchesManagementPanel.php

6 lines

repository/

management/

PhabricatorRepositoryManagementThawWorkflow.php

6 lines

storage/

PhabricatorRepository.php

11 lines

xaction/

PhabricatorRepositoryAutocloseOnlyTransaction.php

4 lines

Diff 47417

View Options

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

View Options

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php

View Options

src/applications/repository/management/PhabricatorRepositoryManagementThawWorkflow.php

View Options

src/applications/repository/storage/PhabricatorRepository.php

View Options

src/applications/repository/xaction/PhabricatorRepositoryAutocloseOnlyTransaction.php

Give "Autoclose Only" repository detail proper getters/settersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47417

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php

src/applications/repository/management/PhabricatorRepositoryManagementThawWorkflow.php

src/applications/repository/storage/PhabricatorRepository.php

src/applications/repository/xaction/PhabricatorRepositoryAutocloseOnlyTransaction.php

Give "Autoclose Only" repository detail proper getters/setters
ClosedPublic
Actions

Revision Contents
Changeset List