Page MenuHomePhabricator

On the Diffusion cluster status page, improve device sort order
ClosedPublic

Authored by epriestley on Nov 15 2018, 1:42 PM.
Tags
None
Referenced Files
F15341041: D19813.diff
Sun, Mar 9, 6:19 PM
Unknown Object (File)
Mon, Mar 3, 7:52 AM
Unknown Object (File)
Mon, Mar 3, 7:52 AM
Unknown Object (File)
Feb 9 2025, 6:40 AM
Unknown Object (File)
Feb 9 2025, 6:40 AM
Unknown Object (File)
Feb 9 2025, 6:40 AM
Unknown Object (File)
Jan 25 2025, 2:36 AM
Unknown Object (File)
Jan 25 2025, 2:36 AM
Subscribers
None

Details

Summary

Ref T13216. See PHI943. When you have a large number of cluster bindings for a repository, the UI sorting can be a bit hard to manage.

One install that regularly cycles repository cluster devices had a couple dozen older disabled bindings, with the enabled bindings intermingled.

Sort the UI:

  • enabled devices come first;
  • in each group, sort by name.
Test Plan

Mixed disabled/enabled bindings, loaded DiffusionRepositoryStorage page with clustering configured. Before: relatively unhelpful sort order. After: more intuitive sort order.

Diff Detail

Repository
rP Phabricator
Branch
cluster1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21164
Build 28778: Run Core Tests
Build 28777: arc lint + arc unit