Page MenuHomePhabricator

On the Diffusion cluster status page, improve device sort order
ClosedPublic

Authored by epriestley on Nov 15 2018, 1:42 PM.
Tags
None
Referenced Files
F19082865: D19813.id47341.diff
Tue, Dec 2, 12:26 PM
F19060498: D19813.id.diff
Sat, Nov 29, 9:27 AM
F19054181: D19813.diff
Fri, Nov 28, 11:01 AM
F18984972: D19813.id47315.diff
Nov 17 2025, 12:49 PM
F18830863: D19813.id.diff
Oct 25 2025, 9:20 AM
F18827656: D19813.diff
Oct 24 2025, 11:19 AM
F18784600: D19813.id.diff
Oct 13 2025, 1:23 PM
F18772193: D19813.id47315.diff
Oct 9 2025, 12:58 AM
Subscribers
None

Details

Summary

Ref T13216. See PHI943. When you have a large number of cluster bindings for a repository, the UI sorting can be a bit hard to manage.

One install that regularly cycles repository cluster devices had a couple dozen older disabled bindings, with the enabled bindings intermingled.

Sort the UI:

  • enabled devices come first;
  • in each group, sort by name.
Test Plan

Mixed disabled/enabled bindings, loaded DiffusionRepositoryStorage page with clustering configured. Before: relatively unhelpful sort order. After: more intuitive sort order.

Diff Detail

Repository
rP Phabricator
Branch
cluster1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21164
Build 28778: Run Core Tests
Build 28777: arc lint + arc unit