Differential D19813

On the Diffusion cluster status page, improve device sort order
ClosedPublic
Actions

Authored by epriestley on Nov 15 2018, 1:42 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13216: 2018 Week 45-47 Bonus Content

Commits

rPab14f49ef87d: On the Diffusion cluster status page, improve device sort order

Summary

Ref T13216. See PHI943. When you have a large number of cluster bindings for a repository, the UI sorting can be a bit hard to manage.

One install that regularly cycles repository cluster devices had a couple dozen older disabled bindings, with the enabled bindings intermingled.

Sort the UI:

enabled devices come first;
in each group, sort by name.

Test Plan

Mixed disabled/enabled bindings, loaded Diffusion → Repository → Storage page with clustering configured. Before: relatively unhelpful sort order. After: more intuitive sort order.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Nov 15 2018, 1:42 PM

Harbormaster completed remote builds in B21164: Diff 47315.Nov 15 2018, 1:44 PM

epriestley requested review of this revision.Nov 15 2018, 1:44 PM

amckinley accepted this revision.Nov 19 2018, 4:14 PM

This revision is now accepted and ready to land.Nov 19 2018, 4:14 PM

Closed by commit rPab14f49ef87d: On the Diffusion cluster status page, improve device sort order (authored by epriestley). · Explain WhyNov 20 2018, 4:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

management/

DiffusionRepositoryStorageManagementPanel.php

33 lines

Diff 47341

View Options

src/applications/diffusion/management/DiffusionRepositoryStorageManagementPanel.php

On the Diffusion cluster status page, improve device sort orderClosedPublicActions