Paths

Table of Contentst

Differential D19789

Update many Phabricator queries for new %Q query semantics
ClosedPublic
Actions

Authored by epriestley on Nov 7 2018, 12:29 PM.

Tags

None

Referenced Files

	F15368602: D19789.id47256.diff
	Wed, Mar 12, 3:03 AM

	Unknown Object (File)
	Fri, Feb 28, 9:36 AM

	Unknown Object (File)
	Wed, Feb 19, 6:27 PM

	Unknown Object (File)
	Feb 9 2025, 2:35 PM

	Unknown Object (File)
	Feb 9 2025, 2:35 PM

	Unknown Object (File)
	Feb 9 2025, 2:35 PM

	Unknown Object (File)
	Feb 9 2025, 2:35 PM

	Unknown Object (File)
	Feb 9 2025, 2:35 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T13217: Upgrading: Hardening of qsprintf()

Commits

rP98690ee326ce: Update many Phabricator queries for new %Q query semantics

Summary

Depends on D19785. Ref T13217. This converts many of the most common clause construction pathways to the new %Q / %LQ / %LO / %LA / %LJ semantics.

Test Plan

Browsed around a bunch, saw fewer warnings and no obvious behavioral errors. The transformations here are generally mechanical (although I did them by hand).

Diff Detail

Repository

Branch

query2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21151
Build 28757: Run Core Tests
Build 28756: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 7 2018, 12:29 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2018, 12:30 PM

Harbormaster failed remote builds in B21105: Diff 47256!

epriestley marked an inline comment as done.Nov 7 2018, 12:30 PM

epriestley added inline comments.

src/applications/calendar/query/PhabricatorCalendarEventQuery.php
512–514	This method has no effect: this is the default behavior of the parent method, so removing it does not change program behavior. (It otherwise needed a signature change, so I just nuked it instead.)

epriestley added a child revision: D19790: Continue making application fixes to Phabricator for changes to %Q semantics.Nov 7 2018, 12:59 PM

epriestley requested review of this revision.Nov 13 2018, 4:53 PM

Herald added a subscriber: hach-que. · View Herald TranscriptNov 13 2018, 4:53 PM

amckinley accepted this revision.Nov 15 2018, 3:12 AM

amckinley added inline comments.

src/applications/chatlog/query/PhabricatorChatLogQuery.php
63	"nul"
src/infrastructure/query/PhabricatorOffsetPagedQuery.php
38	This is just required because `qsprintf` returns objects instead of strings now, right?

This revision is now accepted and ready to land.Nov 15 2018, 3:12 AM

Fix nul vs null.

Harbormaster completed remote builds in B21151: Diff 47302.Nov 15 2018, 3:25 AM

epriestley added inline comments.Nov 15 2018, 11:42 AM

src/infrastructure/query/PhabricatorOffsetPagedQuery.php
38	Yep, exactly.

Closed by commit rP98690ee326ce: Update many Phabricator queries for new %Q query semantics (authored by epriestley). · Explain WhyNov 15 2018, 11:48 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

query/

PhabricatorAuthInviteQuery.php

16 lines

PhabricatorAuthProviderConfigQuery.php

20 lines

PhabricatorAuthSessionQuery.php

22 lines

calendar/

query/

PhabricatorCalendarEventInviteeQuery.php

16 lines

PhabricatorCalendarEventQuery.php

4 lines

chatlog/

query/

PhabricatorChatLogChannelQuery.php

10 lines

PhabricatorChatLogQuery.php

14 lines

config/

query/

PhabricatorConfigEntryQuery.php

14 lines

conpherence/

query/

ConpherenceFulltextQuery.php

10 lines

ConpherenceParticipantCountQuery.php

2 lines

ConpherenceParticipantQuery.php

2 lines

daemon/

query/

PhabricatorDaemonLogQuery.php

17 lines

differential/

query/

DifferentialInlineCommentQuery.php

20 lines

DifferentialRevisionQuery.php

57 lines

diffusion/

query/

DiffusionLintCountQuery.php

8 lines

DiffusionSymbolQuery.php

16 lines

diviner/

query/

DivinerAtomQuery.php

38 lines

DivinerBookQuery.php

18 lines

files/

query/

PhabricatorFileChunkQuery.php

16 lines

flag/

query/

PhabricatorFlagQuery.php

14 lines

fund/

query/

FundBackerQuery.php

16 lines

herald/

query/

HeraldRuleQuery.php

22 lines

HeraldTranscriptQuery.php

12 lines

legalpad/

query/

LegalpadDocumentSignatureQuery.php

20 lines

oauthserver/

query/

PhabricatorOAuthServerClientQuery.php

12 lines

phlux/

query/

PhluxVariableQuery.php

12 lines

pholio/

query/

PholioImageQuery.php

14 lines

phortune/

query/

PhortuneAccountQuery.php

2 lines

PhortuneCartQuery.php

2 lines

PhortuneChargeQuery.php

2 lines

PhortuneMerchantQuery.php

2 lines

PhortunePaymentProviderConfigQuery.php

2 lines

PhortuneProductQuery.php

4 lines

PhortunePurchaseQuery.php

2 lines

PhortuneSubscriptionQuery.php

2 lines

phragment/

query/

PhragmentFragmentQuery.php

16 lines

PhragmentFragmentVersionQuery.php

16 lines

PhragmentSnapshotChildQuery.php

14 lines

PhragmentSnapshotQuery.php

22 lines

phrequent/

query/

PhrequentUserTimeQuery.php

2 lines

releeph/

query/

ReleephBranchQuery.php

14 lines

ReleephProductQuery.php

14 lines

ReleephRequestQuery.php

18 lines

search/

query/

PhabricatorSavedQueryQuery.php

12 lines

tokens/

query/

PhabricatorTokenCountQuery.php

6 lines

transactions/

query/

PhabricatorApplicationTransactionCommentQuery.php

22 lines

infrastructure/

daemon/

workers/

query/

PhabricatorWorkerLeaseQuery.php

36 lines

PhabricatorWorkerTaskQuery.php

18 lines

PhabricatorWorkerTriggerQuery.php

16 lines

edges/

query/

PhabricatorEdgeQuery.php

10 lines

query/

PhabricatorOffsetPagedQuery.php

10 lines

PhabricatorQuery.php

50 lines

policy/

PhabricatorCursorPagedPolicyAwareQuery.php

45 lines

storage/

lisk/

17 lines

Diff 47302

src/applications/auth/query/PhabricatorAuthInviteQuery.php

Loading...

src/applications/auth/query/PhabricatorAuthProviderConfigQuery.php

Loading...

src/applications/auth/query/PhabricatorAuthSessionQuery.php

Loading...

src/applications/calendar/query/PhabricatorCalendarEventInviteeQuery.php

Loading...

src/applications/calendar/query/PhabricatorCalendarEventQuery.php

Loading...

src/applications/chatlog/query/PhabricatorChatLogChannelQuery.php

Loading...

src/applications/chatlog/query/PhabricatorChatLogQuery.php

Loading...

src/applications/config/query/PhabricatorConfigEntryQuery.php

Loading...

src/applications/conpherence/query/ConpherenceFulltextQuery.php

Loading...

src/applications/conpherence/query/ConpherenceParticipantCountQuery.php

Loading...

src/applications/conpherence/query/ConpherenceParticipantQuery.php

Loading...

src/applications/daemon/query/PhabricatorDaemonLogQuery.php

Loading...

src/applications/differential/query/DifferentialInlineCommentQuery.php

Loading...

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...

src/applications/diffusion/query/DiffusionLintCountQuery.php

Loading...

src/applications/diffusion/query/DiffusionSymbolQuery.php

Loading...

src/applications/diviner/query/DivinerAtomQuery.php

Loading...

src/applications/diviner/query/DivinerBookQuery.php

Loading...

src/applications/files/query/PhabricatorFileChunkQuery.php

Loading...

src/applications/flag/query/PhabricatorFlagQuery.php

Loading...

src/applications/fund/query/FundBackerQuery.php

Loading...

src/applications/herald/query/HeraldRuleQuery.php

Loading...

src/applications/herald/query/HeraldTranscriptQuery.php

Loading...

src/applications/legalpad/query/LegalpadDocumentSignatureQuery.php

Loading...

src/applications/oauthserver/query/PhabricatorOAuthServerClientQuery.php

Loading...

src/applications/phlux/query/PhluxVariableQuery.php

Loading...

src/applications/pholio/query/PholioImageQuery.php

Loading...

src/applications/phortune/query/PhortuneAccountQuery.php

Loading...

src/applications/phortune/query/PhortuneCartQuery.php

Loading...

src/applications/phortune/query/PhortuneChargeQuery.php

Loading...

src/applications/phortune/query/PhortuneMerchantQuery.php

Loading...

src/applications/phortune/query/PhortunePaymentProviderConfigQuery.php

Loading...

src/applications/phortune/query/PhortuneProductQuery.php

Loading...

src/applications/phortune/query/PhortunePurchaseQuery.php

Loading...

src/applications/phortune/query/PhortuneSubscriptionQuery.php

Loading...

src/applications/phragment/query/PhragmentFragmentQuery.php

Loading...

src/applications/phragment/query/PhragmentFragmentVersionQuery.php

Loading...

src/applications/phragment/query/PhragmentSnapshotChildQuery.php

Loading...

src/applications/phragment/query/PhragmentSnapshotQuery.php

Loading...

src/applications/phrequent/query/PhrequentUserTimeQuery.php

Loading...

src/applications/releeph/query/ReleephBranchQuery.php

Loading...

src/applications/releeph/query/ReleephProductQuery.php

Loading...

src/applications/releeph/query/ReleephRequestQuery.php

Loading...

src/applications/search/query/PhabricatorSavedQueryQuery.php

Loading...

src/applications/tokens/query/PhabricatorTokenCountQuery.php

Loading...

src/applications/transactions/query/PhabricatorApplicationTransactionCommentQuery.php

Loading...

src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php

Loading...

src/infrastructure/daemon/workers/query/PhabricatorWorkerTaskQuery.php

Loading...

src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php

Loading...

src/infrastructure/edges/query/PhabricatorEdgeQuery.php

Loading...

src/infrastructure/query/PhabricatorOffsetPagedQuery.php

Loading...

src/infrastructure/query/PhabricatorQuery.php

Loading...

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...

src/infrastructure/storage/lisk/LiskDAO.php

Loading...