Page MenuHomePhabricator

Update many Phabricator queries for new %Q query semantics
ClosedPublic

Authored by epriestley on Nov 7 2018, 12:29 PM.

Details

Summary

Depends on D19785. Ref T13217. This converts many of the most common clause construction pathways to the new %Q / %LQ / %LO / %LA / %LJ semantics.

Test Plan

Browsed around a bunch, saw fewer warnings and no obvious behavioral errors. The transformations here are generally mechanical (although I did them by hand).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 7 2018, 12:29 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2018, 12:30 PM
Harbormaster failed remote builds in B21105: Diff 47256!
epriestley marked an inline comment as done.Nov 7 2018, 12:30 PM
epriestley added inline comments.
src/applications/calendar/query/PhabricatorCalendarEventQuery.php
512–514

This method has no effect: this is the default behavior of the parent method, so removing it does not change program behavior.

(It otherwise needed a signature change, so I just nuked it instead.)

epriestley requested review of this revision.Tue, Nov 13, 4:53 PM
amckinley accepted this revision.Thu, Nov 15, 3:12 AM
amckinley added inline comments.
src/applications/chatlog/query/PhabricatorChatLogQuery.php
63

"nul"

src/infrastructure/query/PhabricatorOffsetPagedQuery.php
38

This is just required because qsprintf returns objects instead of strings now, right?

This revision is now accepted and ready to land.Thu, Nov 15, 3:12 AM
epriestley updated this revision to Diff 47302.Thu, Nov 15, 3:24 AM
epriestley marked an inline comment as done.
  • Fix nul vs null.
epriestley added inline comments.Thu, Nov 15, 11:42 AM
src/infrastructure/query/PhabricatorOffsetPagedQuery.php
38

Yep, exactly.

This revision was automatically updated to reflect the committed changes.