Page MenuHomePhabricator

Update many Phabricator queries for new %Q query semantics
ClosedPublic

Authored by epriestley on Nov 7 2018, 12:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 19, 3:50 PM
Unknown Object (File)
Feb 3 2024, 7:49 PM
Unknown Object (File)
Dec 22 2023, 12:42 AM
Unknown Object (File)
Dec 22 2023, 12:42 AM
Unknown Object (File)
Dec 22 2023, 12:42 AM
Unknown Object (File)
Dec 22 2023, 12:42 AM
Unknown Object (File)
Dec 14 2023, 4:49 AM
Unknown Object (File)
Dec 13 2023, 8:01 AM
Subscribers

Details

Summary

Depends on D19785. Ref T13217. This converts many of the most common clause construction pathways to the new %Q / %LQ / %LO / %LA / %LJ semantics.

Test Plan

Browsed around a bunch, saw fewer warnings and no obvious behavioral errors. The transformations here are generally mechanical (although I did them by hand).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2018, 12:30 PM
Harbormaster failed remote builds in B21105: Diff 47256!
epriestley added inline comments.
src/applications/calendar/query/PhabricatorCalendarEventQuery.php
512–514

This method has no effect: this is the default behavior of the parent method, so removing it does not change program behavior.

(It otherwise needed a signature change, so I just nuked it instead.)

amckinley added inline comments.
src/applications/chatlog/query/PhabricatorChatLogQuery.php
63

"nul"

src/infrastructure/query/PhabricatorOffsetPagedQuery.php
38

This is just required because qsprintf returns objects instead of strings now, right?

This revision is now accepted and ready to land.Nov 15 2018, 3:12 AM
epriestley marked an inline comment as done.
  • Fix nul vs null.
src/infrastructure/query/PhabricatorOffsetPagedQuery.php
38

Yep, exactly.

This revision was automatically updated to reflect the committed changes.