Page MenuHomePhabricator

Make SELECT construction in PolicyAwareQuery safer
ClosedPublic

Authored by epriestley on Nov 7 2018, 10:40 AM.

Details

Summary

Depends on D19784. Ref T13217. Reduce uses of unsafe %Q in SELECT construction.

Test Plan

This reduces the number of safety warnings when loading Phabricator home from ~900 to ~800.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 7 2018, 10:40 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2018, 10:41 AM
Harbormaster failed remote builds in B21100: Diff 47251!
epriestley requested review of this revision.Tue, Nov 13, 4:53 PM

Failures are just a dependency issue.

amckinley accepted this revision.Wed, Nov 14, 7:24 PM
This revision is now accepted and ready to land.Wed, Nov 14, 7:24 PM
This revision was automatically updated to reflect the committed changes.