Page MenuHomePhabricator
Differential D19785

Make SELECT construction in PolicyAwareQuery safer
ClosedPublic
Actions

Authored by epriestley on Nov 7 2018, 10:40 AM.
Tags
None
Referenced Files
F18744728: D19785.id.diff
Fri, Oct 3, 3:58 AM
F18733824: D19785.id.diff
Tue, Sep 30, 10:42 PM
F18708644: D19785.id.diff
Sun, Sep 28, 10:18 PM
F18684384: D19785.diff
Fri, Sep 26, 9:20 AM
F18658711: D19785.diff
Tue, Sep 23, 7:59 AM
F18643898: D19785.diff
Fri, Sep 19, 3:22 AM
F18568721: D19785.id47300.diff
Sep 10 2025, 12:23 AM
F18568718: D19785.id47251.diff
Sep 10 2025, 12:23 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13217: Upgrading: Hardening of qsprintf()
Commits
rP64b52b9952dd: Make SELECT construction in PolicyAwareQuery safer
Summary

Depends on D19784. Ref T13217. Reduce uses of unsafe %Q in SELECT construction.

Test Plan

This reduces the number of safety warnings when loading Phabricator home from ~900 to ~800.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Nov 7 2018, 10:40 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2018, 10:41 AM
Harbormaster failed remote builds in B21100: Diff 47251!
epriestley added a child revision: D19789: Update many Phabricator queries for new %Q query semantics.Nov 7 2018, 12:29 PM
epriestley requested review of this revision.Nov 13 2018, 4:53 PM

Failures are just a dependency issue.

amckinley accepted this revision.Nov 14 2018, 7:24 PM
This revision is now accepted and ready to land.Nov 14 2018, 7:24 PM
Closed by commit rP64b52b9952dd: Make SELECT construction in PolicyAwareQuery safer (authored by epriestley). · Explain WhyNov 14 2018, 11:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
query/
4 lines
infrastructure/
query/
21 lines
policy/
4 lines

Diff 47300

View Options

src/applications/repository/query/PhabricatorRepositoryQuery.php

Loading...
View Options

src/infrastructure/query/PhabricatorQuery.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility