Page MenuHomePhabricator

Make SELECT construction in PolicyAwareQuery safer
ClosedPublic

Authored by epriestley on Nov 7 2018, 10:40 AM.
Tags
None
Referenced Files
F15577953: D19785.id.diff
Tue, May 6, 4:59 PM
F15557213: D19785.id47300.diff
Mon, Apr 28, 8:29 PM
F15552672: D19785.id.diff
Sun, Apr 27, 9:59 PM
F15546459: D19785.diff
Sat, Apr 26, 3:43 PM
F15545130: D19785.diff
Sat, Apr 26, 9:05 AM
F15524286: D19785.id47300.diff
Mon, Apr 21, 7:10 AM
F15522789: D19785.id47251.diff
Sun, Apr 20, 9:26 PM
F15520758: D19785.id47300.diff
Sun, Apr 20, 8:03 AM
Subscribers
None

Details

Summary

Depends on D19784. Ref T13217. Reduce uses of unsafe %Q in SELECT construction.

Test Plan

This reduces the number of safety warnings when loading Phabricator home from ~900 to ~800.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2018, 10:41 AM
Harbormaster failed remote builds in B21100: Diff 47251!

Failures are just a dependency issue.

This revision is now accepted and ready to land.Nov 14 2018, 7:24 PM
This revision was automatically updated to reflect the committed changes.