Update many Phabricator queries for new %Q query semantics
ClosedPublic
Actions

Authored by epriestley on Nov 7 2018, 12:29 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13217: Upgrading: Hardening of qsprintf()

Commits

rP98690ee326ce: Update many Phabricator queries for new %Q query semantics

Summary

Depends on D19785. Ref T13217. This converts many of the most common clause construction pathways to the new %Q / %LQ / %LO / %LA / %LJ semantics.

Test Plan

Browsed around a bunch, saw fewer warnings and no obvious behavioral errors. The transformations here are generally mechanical (although I did them by hand).

Diff Detail

Repository

rP Phabricator

Branch

qobject7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21105
Build 28688: Run Core Tests
Build 28687: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1 ms	ConpherenceRoomTestCase::Unknown Unit Message ("") EXCEPTION (XsprintfUnknownConversionException): Unknown conversion LQ. #0 /core/data/drydock/workingcopy-74/repo/libphutil/src/xsprintf/qsprintf.php(282): qsprintf_check_scalar_type(Array, 'LQ', 'SELECT %LQ') #1 /core/data/drydock/workingcopy-74/repo/libphutil/src/xsprintf/qsprintf.php(134): qsprintf_check_type(Array, 'LQ', 'SELECT %LQ')
	1 ms	ConpherenceRoomTestCase::Unknown Unit Message ("") EXCEPTION (XsprintfUnknownConversionException): Unknown conversion LQ. #0 /core/data/drydock/workingcopy-74/repo/libphutil/src/xsprintf/qsprintf.php(282): qsprintf_check_scalar_type(Array, 'LQ', 'SELECT %LQ') #1 /core/data/drydock/workingcopy-74/repo/libphutil/src/xsprintf/qsprintf.php(134): qsprintf_check_type(Array, 'LQ', 'SELECT %LQ')
	1 ms	ConpherenceRoomTestCase::Unknown Unit Message ("") EXCEPTION (XsprintfUnknownConversionException): Unknown conversion LQ. #0 /core/data/drydock/workingcopy-74/repo/libphutil/src/xsprintf/qsprintf.php(282): qsprintf_check_scalar_type(Array, 'LQ', 'SELECT %LQ') #1 /core/data/drydock/workingcopy-74/repo/libphutil/src/xsprintf/qsprintf.php(134): qsprintf_check_type(Array, 'LQ', 'SELECT %LQ')
	1 ms	ConpherenceRoomTestCase::Unknown Unit Message ("") EXCEPTION (XsprintfUnknownConversionException): Unknown conversion LQ. #0 /core/data/drydock/workingcopy-74/repo/libphutil/src/xsprintf/qsprintf.php(282): qsprintf_check_scalar_type(Array, 'LQ', 'SELECT %LQ') #1 /core/data/drydock/workingcopy-74/repo/libphutil/src/xsprintf/qsprintf.php(134): qsprintf_check_type(Array, 'LQ', 'SELECT %LQ')
	1 ms	DiffusionURITestCase::Unknown Unit Message ("") EXCEPTION (XsprintfUnknownConversionException): Unknown conversion LQ. #0 /core/data/drydock/workingcopy-74/repo/libphutil/src/xsprintf/qsprintf.php(282): qsprintf_check_scalar_type(Array, 'LQ', 'SELECT %LQ') #1 /core/data/drydock/workingcopy-74/repo/libphutil/src/xsprintf/qsprintf.php(134): qsprintf_check_type(Array, 'LQ', 'SELECT %LQ')
		View Full Test Results (113 Failed · 297 Passed)

Event Timeline

epriestley created this revision.Nov 7 2018, 12:29 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2018, 12:30 PM

Harbormaster failed remote builds in B21105: Diff 47256!

epriestley marked an inline comment as done.Nov 7 2018, 12:30 PM

epriestley added inline comments.

src/applications/calendar/query/PhabricatorCalendarEventQuery.php
512–514	This method has no effect: this is the default behavior of the parent method, so removing it does not change program behavior. (It otherwise needed a signature change, so I just nuked it instead.)

epriestley added a child revision: D19790: Continue making application fixes to Phabricator for changes to %Q semantics.Nov 7 2018, 12:59 PM

epriestley requested review of this revision.Nov 13 2018, 4:53 PM

Herald added a subscriber: hach-que. · View Herald TranscriptNov 13 2018, 4:53 PM

amckinley accepted this revision.Nov 15 2018, 3:12 AM

amckinley added inline comments.

src/applications/chatlog/query/PhabricatorChatLogQuery.php
63	"nul"
src/infrastructure/query/PhabricatorOffsetPagedQuery.php
38	This is just required because `qsprintf` returns objects instead of strings now, right?