Page MenuHomePhabricator

Make %LO, %LA, %LQ and %LJ more lax in what they accept (warnings instead of exceptions)
ClosedPublic

Authored by epriestley on Nov 7 2018, 11:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 6:28 AM
Unknown Object (File)
Sat, Nov 23, 8:27 AM
Unknown Object (File)
Tue, Nov 12, 10:20 PM
Unknown Object (File)
Tue, Nov 12, 9:09 PM
Unknown Object (File)
Oct 25 2024, 12:39 AM
Unknown Object (File)
Oct 18 2024, 7:41 PM
Unknown Object (File)
Oct 16 2024, 2:57 AM
Unknown Object (File)
Oct 6 2024, 10:53 PM
Subscribers
None

Details

Summary

Depends on D19786. Ref T13217. I had imagined making these new conversions strict, but a lot of stuff breaks when we do because they make sense to use in base classes like CursorPagedPolicyAwareQuery, and it's hard to completely fix all the downstream classes in one fell swoop.

Instead, let them warn for now (like %Q) and we can make them stricter in a future change.

Test Plan

In Phabricator, saw warnings instead of immediate fatals when strings are passed to these conversions.

Diff Detail

Repository
rPHU libphutil
Branch
qobject8
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/xsprintf/qsprintf.php:182XHP16TODO Comment
Advicesrc/xsprintf/qsprintf.php:365XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 21102
Build 28682: Run Core Tests
Build 28681: arc lint + arc unit